Bugfixes for issue 3+4 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king with new versions of orcaslicer. Added lower()-method to catch different cases
|
Hey thanks for your efforts. The problem is not that the comments changed, it's the marlin flavour. I'm guessing you are using marlin(legacy) and probably a Bambu printer. I'm currently working on detecting the Marlinflavour and making the script account for that. |
|
Yeah, your right with me using a BambuPrinter. Nice catch, I didn't thought that the feature will be flavor dependent for the different slicers, but it makes sense. With the travelmoves, have a look. I think it works. And also thanks for the script, it is working really well and has some really nice results already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed TYPE to FEATURE as it seems the new way in orcaslicer.
Additionally bugfixes that with travel moves on top surface some moves are neglected when calculating the new movement