implement cache for provider instance #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lingtonglu
reviewed
Aug 10, 2025
| def _get_or_create_adapter(self, provider_name: str, base_url: str | None = None, config: dict[str, Any] | None = None) -> ProviderAdapter: | ||
| """Get an adapter instance from cache or create a new one""" | ||
| # Create a cache key that includes provider name, base_url, and config hash | ||
| config_hash = hash(frozenset((config or {}).items())) |
There was a problem hiding this comment.
Write a dedicated function in the cache file to create/get/invalidate such cache
There was a problem hiding this comment.
Oh wait, it's not an actual "cache". NVM, this should be good
lingtonglu
reviewed
Aug 10, 2025
| f"Cached models for provider {provider_name} (TTL: {cls._models_cache_ttl}s)" | ||
| ) | ||
|
|
||
| def _get_adapters(self) -> dict[str, ProviderAdapter]: |
There was a problem hiding this comment.
I don't see any usage of such function. I think we could remove it.
Also, in the init function, we do self.adapters = self._get_adapters(). It's not needed as we don't use the member variable adapters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.