PR for all MapR docker containers #21
Conversation
This image contains installation of all mapr related softwares and there dependencies
This contaner is enabled with security on both MapR cluster and Hive
The changes includes a new function expose_mapr and the shell script to wait for MapR , also this changes will enable tests to switch user when the container is not MapR.
Adding missing sshd start in Docker-base
This changes will make maprcli wait for MapR ticket in wardenTracker
ArturGajowy
left a comment
ArturGajowy
left a comment
There was a problem hiding this comment.
Partial review done.
| # CONFIGURE SSH | ||
| && chkconfig sshd on \ | ||
| && grep -rl '#Port 22' /etc/ssh/sshd_config | xargs sed -i 's/#Port 22/Port 22/g' \ | ||
| && service sshd start \ |
There was a problem hiding this comment.
why would that be needed? This is during image build, the newly started container will have sshd down anyway (except for cases when supervisor.d will spin it up)
| ADD files/maprtech.repo /etc/yum.repos.d/maprtech.repo | ||
| COPY files/id_rsa.pub /root/ | ||
| RUN yum update -y \ | ||
| # ... GET MapRGPG KEY |
teradatalabs/mapr52-base/Dockerfile
Outdated
| && rpm --import http://package.mapr.com/releases/pub/maprgpg.key \ | ||
|
|
||
| # INSTALL UTILITY SOFTWARE | ||
| && yum install -y iputils vim openssh-server openssh-clients sudo lsof \ |
There was a problem hiding this comment.
that's not needed, until proven otherwise
There was a problem hiding this comment.
apart from vim all others are required
| && yum install -y iputils vim openssh-server openssh-clients sudo lsof \ | ||
| # CONFIGURE SSH | ||
| && chkconfig sshd on \ | ||
| && grep -rl '#Port 22' /etc/ssh/sshd_config | xargs sed -i 's/#Port 22/Port 22/g' \ |
There was a problem hiding this comment.
why is that needed? The other containers expose sshd as well and they don't seem to be sed-ing the 22 Port in config anywhere AFAIR?
There was a problem hiding this comment.
Its not working without that , other containers will all have same problems when some one will ssh hadoop-master from outside.
| && grep -rl '#Port 22' /etc/ssh/sshd_config | xargs sed -i 's/#Port 22/Port 22/g' \ | ||
|
|
||
| # INSTALL MAPR | ||
| && yum install -y mapr-fileserver mapr-nfs mapr-nodemanager mapr-cldb \ |
There was a problem hiding this comment.
squash into a single yum install invocation
teradatalabs/mapr52-base/README.md
Outdated
| # mapr52-base | ||
|
|
||
| Docker image with all MapR related softwares installed and there dependencies. |
There was a problem hiding this comment.
software (it's uncountable)
teradatalabs/mapr52-base/README.md
Outdated
| @@ -0,0 +1,9 @@ | |||
| # mapr52-base | |||
| supervisorctl start socks-proxy | ||
|
|
||
| # CONFIGURE MAPR | ||
| /opt/mapr/server/configure.sh -N mycluster -Z localhost -C localhost -HS localhost -no-autostart |
| /opt/mapr/server/configure.sh -R | ||
|
|
||
| # WAIT FOR WARDEN TO START ALL THE SERVICES | ||
| sh /root/wardenTracker.sh |
| @@ -0,0 +1,54 @@ | |||
| #!/bin/bash | |||
|
|
|||
| hname=$(hostname) | |||
There was a problem hiding this comment.
I htink there's a whole lot of comments that haven't been applied for this file
There was a problem hiding this comment.
@ArturGajowy can you review Kerberbos MapR which is new,
also the test changes we did I will also look into the old PR comments and fix together
so that the build finishes under the 50 minutes mark
so that the build isn't terminated after long time without output
ArturGajowy
force-pushed
the
MapR-Master
branch
from
c4a7549 to
702f0af
Compare
|
I think I'll wait till you apply the comments from the previous review, as
they might apply to the kerberos image as well
…On Tue, Apr 11, 2017 at 3:49 PM Ashish Singh ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In teradatalabs/mapr52-hive/files/wardenTracker.sh
<#21 (comment)>:
> @@ -0,0 +1,54 @@
+#!/bin/bash
+
+hname=$(hostname)
@ArturGajowy <https://github.com/ArturGajowy> can you review Kerberbos
MapR which is new also the test changes we did
I will also look into the old PR comments and fix together
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAcFbQE2Rnpu4-FQkPYrmp7xCrycIHPgks5ru4T3gaJpZM4M16co>
.
|
|
@ArturGajowy @petroav |
PR for all MapR docker containers
Please review and give feedback @ArturGajowy @akshatnair @petroav @sanjay990