Skip to content

Update to newest complementary#60

Draft
Zaraney wants to merge 3 commits into
devfrom
UPDATE-TO-NEWEST-COMPLEMENTARY
Draft

Update to newest complementary#60
Zaraney wants to merge 3 commits into
devfrom
UPDATE-TO-NEWEST-COMPLEMENTARY

Conversation

@Zaraney

@Zaraney Zaraney commented May 28, 2026

Copy link
Copy Markdown
Contributor

What is the new behavior?

This section describes what this PR is about. It should be a clear and concise description concerning what this PR is for, why this PR is needed, and why it should be accepted.
Linking an issue can be used alternatively to writing a description.

Implementation Details

Any implementations in this PR that should be carefully looked over, or that could/should have alternate solutions proposed.

Outcome

A short description of what this PR added/fixed/changed/removed.
For correct linking of issues please use any of the Closes/Fixes/Resolves keywords. Example: When a PR is fixing a bug use "Fixes: #number-of-bug"

Additional Information

This section is for screenshots to demonstrate any GUI or rendering changes, or any other additional information that reviewers should be aware of.

Potential Compatibility Issues

This section is for defining possible compatibility issues.

Enter your Discord nickname, if your PR is successfully accepted, you will be given the Contributor role

Please fill in as much useful information as possible. Also, please remove all unused sections, including this and the other explanations.

@Zaraney Zaraney marked this pull request as ready for review May 28, 2026 18:04
@Zaraney Zaraney marked this pull request as draft May 28, 2026 18:05
@XanloZz

XanloZz commented Jul 3, 2026

Copy link
Copy Markdown

If u can fix this. I found error in file shaders\lib\atmospherics\nightNebula.glsl on world_moon.
net.minecraft.server.ChainedJsonException: Invalid shaders/core/sky_basic.json: The call m_166612_ is not cancellable.

#ifdef NEBULA_AT_DAY //unused yet
float nightHideFactor = 1.0;
#else
#ifdef SPACE_TRANSITION
float nightHideFactor = mix(min1(nightFactor * 2.0), 1.0, getAtmosphereFadeoutFactor);
#else
float nightHideFactor = min(nightFactor * 2.0);
#endif
#endif

My fix:

float nightHideFactor = min(nightFactor * 2.0);
#ifdef NEBULA_AT_DAY //unused yet
nightHideFactor = 1.0;
#endif
#ifdef SPACE_TRANSITION
nightHideFactor = mix(min1(nightFactor * 2.0), 1.0, getAtmosphereFadeoutFactor);
#endif

Also there lost float that can be used later in code, idk maybe this is what its need to be.
float nebulaFactor = pow2(VdotUFactor * min1(nightFactor * 2.0));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants