You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This section describes what this PR is about. It should be a clear and concise description concerning what this PR is for, why this PR is needed, and why it should be accepted. Linking an issue can be used alternatively to writing a description.
Implementation Details
Any implementations in this PR that should be carefully looked over, or that could/should have alternate solutions proposed.
Outcome
A short description of what this PR added/fixed/changed/removed. For correct linking of issues please use any of the Closes/Fixes/Resolves keywords. Example: When a PR is fixing a bug use "Fixes: #number-of-bug"
Additional Information
This section is for screenshots to demonstrate any GUI or rendering changes, or any other additional information that reviewers should be aware of.
Potential Compatibility Issues
This section is for defining possible compatibility issues.
Enter your Discord nickname, if your PR is successfully accepted, you will be given the Contributor role
Please fill in as much useful information as possible. Also, please remove all unused sections, including this and the other explanations.
If u can fix this. I found error in file shaders\lib\atmospherics\nightNebula.glsl on world_moon.
net.minecraft.server.ChainedJsonException: Invalid shaders/core/sky_basic.json: The call m_166612_ is not cancellable.
Also there lost float that can be used later in code, idk maybe this is what its need to be.
float nebulaFactor = pow2(VdotUFactor * min1(nightFactor * 2.0));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the new behavior?
This section describes what this PR is about. It should be a clear and concise description concerning what this PR is for, why this PR is needed, and why it should be accepted.
Linking an issue can be used alternatively to writing a description.
Implementation Details
Any implementations in this PR that should be carefully looked over, or that could/should have alternate solutions proposed.
Outcome
A short description of what this PR added/fixed/changed/removed.
For correct linking of issues please use any of the Closes/Fixes/Resolves keywords. Example: When a PR is fixing a bug use "Fixes: #number-of-bug"
Additional Information
This section is for screenshots to demonstrate any GUI or rendering changes, or any other additional information that reviewers should be aware of.
Potential Compatibility Issues
This section is for defining possible compatibility issues.
Enter your Discord nickname, if your PR is successfully accepted, you will be given the Contributor role
Please fill in as much useful information as possible. Also, please remove all unused sections, including this and the other explanations.