add keep_on_remove param #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Please add the Smoke and Sanity test for review on both PR. |
|
My only comment on this is that there are two pull requests, keep_on_remove for template disks (this pull request), and the other pull request from same contributor to allow keep_on_remove for additional disks. Could there be a confusion on both if the variable name is the same in both places? This pull request would use a "list" type variable while the other PR is a boolean type variable. Functionally both can work and coincide, but I wonder if this one should use a different variable name like "keep_template_disks_on_remove", or something that makes more sense |
dmpopoff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manage keep or not template (OS) discs in case of VM destruction.