Refactor TestSelection class to implement IEnumerable interface #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se Hashset internally as collection
|
If this is actually ready and only blocked because of AppVeyor, I can merge it on my machine and push straight to main. |
…se Hashset internally as collection
…ic/testcentric-gui into TestSelectionExtension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #1111
The root cause of that crash was that the code didn't handle checking/unchecking TestGroups nodes so far.
This solution improves the TestSelection class so that either TestNodes or TestGroups maybe added. For that purpose the internal implementation was changed: the TestSelection class exposes only the interface IEnumerable<TestNode> and uses a private Hashset for the list of nodes internally. So the choice about using a Hashset or List is only an internal implementation detail of that class.
As a consequence several code locations must be adapted. These adaptations were not conceptual changes, but mostly using Linq to access the IEnumerable<TestNode>.