Conversation
PR Reviewer Guide 🔍(Review updated until commit b3cc750)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to b3cc750
Previous suggestionsSuggestions up to commit a6c52ea
Suggestions up to commit 614f033
Suggestions up to commit 4c3ca47
Suggestions up to commit 5db654b
Suggestions up to commit 33c33a4
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
f3ca647 to
33c33a4
Compare
33c33a4 to
5db654b
Compare
@nsaulnier-ti Please address this |
a6c52ea to
b3cc750
Compare
|
/agentic_review |
Code Review by Qodo
1. Cache key line too long
|
----------- MAJOR UPDATES: * Add support for AM62x to the OpenPRU repo [1] * Add support for AM62x & AM64x Linux RPMsg * Add support for AM243x & AM64x MCU+ SDK 11.1 & 11.2 [2] Supported processors: AM243x, AM261x, AM263Px, AM263x, AM62x, AM64x Supported SDK versions: Refer to https://github.com/TexasInstruments/open-pru/blob/main/docs/release_notes.md ACADEMIES: PRU Academy for AM243x at https://dev.ti.com/tirex/explore/node?isTheia=false&node=A__AB.mSUi9ihL.a5hIt1grfw__AM24X-ACADEMY__ZPSnq-h__LATEST PRU Academy for AM64x at https://dev.ti.com/tirex/explore/node?isTheia=false&node=A__AB.mSUi9ihL.a5hIt1grfw__AM64-ACADEMY__WI1KRXP__LATEST ADDITIONAL UPDATES & BUGFIXES: * Bugfix: release notes > compatible SDKs > v2025.00.00 * AM26x projects ONLY support MCU+ 10.2 in both v2025.00.00 & v2026.00.00 * Add libraries for PRU to communicate with Linux through the RPMsg Inter-Processor Communication (IPC) protocol * source/rpmsg * Add examples/rpmsg_echo_linux * RPMsg example between Linux <--> PRU * supports AM62x & AM64x * Add examples/fir * Implement 64-tap Finite Impulse Respose (FIR) filter on PRU * supports AM243x * Add examples/multicore_scheduler * Use IEP timer + Task Manager to schedule tasks across all cores * supports AM243x * Add github workflows to validate OpenPRU make infrastructure * Bugfix: AM26x projects * remove unneeded makefile includes * remove empty example.syscfg files DETAILS: [1] * Officially add AM62x support for building PRU firmware * Add support for AM62x to these existing OpenPRU projects: * Getting Started Labs, empty, empty_c [2] * Adding support for AM243x & AM64x MCU+ SDK 11.1 & 11.2 breaks backwards compatibility with previous AM243x & AM64x MCU+ SDK releases. For more information on building an OpenPRU project with an earlier version of MCU+ SDK, refer to https://github.com/TexasInstruments/open-pru/blob/main/docs/using_older_sdks_with_open_pru.md * This version of OpenPRU does NOT update the AM26x MCU+ build infrastructure. Both v2025.00.00 and v2026.00.00 are only compatible with AM26x MCU+ SDK 10.2. For more information about building an AM26x OpenPRU project with an earlier version of MCU+ SDK, refer to https://github.com/TexasInstruments/open-pru/blob/main/docs/using_older_sdks_with_open_pru.md Signed-off-by: Nick Saulnier <nsaulnier@ti.com>
b3cc750 to
e953750
Compare
Review Summary by QodoRelease notes v2026.00.00 with AM62x support and SDK updates
WalkthroughsDescription• Restructure release notes with v2026.00.00 as primary version • Add AM62x support and RPMsg IPC communication features • Update SDK compatibility tables for AM243x & AM64x MCU+ 11.1-11.2 • Document new examples: rpmsg_echo_linux, fir, multicore_scheduler • Add guidance for reverting MCU+ SDK 11.1 makefile updates Diagramflowchart LR
A["v2026.00.00 Release"] --> B["AM62x Support Added"]
A --> C["RPMsg IPC Libraries"]
A --> D["MCU+ SDK 11.1-11.2"]
C --> E["rpmsg_echo_linux Example"]
D --> F["AM243x & AM64x Updates"]
B --> G["Getting Started Labs"]
F --> H["Makefile Infrastructure"]
A --> I["New Examples: FIR, Scheduler"]
File Changes1. docs/release_notes.md
|
|
Persistent review updated to latest commit e953750 |
Signed-off-by: Nick Saulnier <nsaulnier@ti.com>
Add AM62x to the workflow build. Since there is no AM62x MCU+ SDK support for controlling the PRU cores, only build the PRU firmware. This might need to be modified if and when we add Linux kernel or Linux userspace code that needs to be compiled for the A53 cores. Signed-off-by: Nick Saulnier <nsaulnier@ti.com>
Review Summary by QodoAdd AM62x/AM64x CI support and update v2026.00.00 release notes
WalkthroughsDescription• Add AM62x and AM64x support to CI/CD workflows • Update release notes with v2026.00.00 details and SDK compatibility • Add MCU+ SDK 11.1/11.2 migration guidance for older SDK versions • Restructure documentation with expanded release notes sections Diagramflowchart LR
CI["CI Workflow<br/>makefile.yml"]
SDK["SDK Support<br/>AM64x 11.02.00.24<br/>AM62x"]
RN["Release Notes<br/>v2026.00.00"]
MIG["Migration Guide<br/>SDK 11.1/11.2"]
CI -- "Add AM64x/AM62x<br/>build targets" --> SDK
SDK -- "Document in" --> RN
RN -- "Link to" --> MIG
File Changes1. .github/workflows/makefile.yml
|
|
Persistent review updated to latest commit 048e6a9 |
|
Responding to the AI review:
|
|
@pratheesh-ti added support to the github build infrastructure to build AM64x w/ MCU+ SDK 11.2, and AM62x with no MCU+ SDK dependencies |
| * LCD_interface: AM243x | ||
| * logic_scope: AM243x | ||
| * pru_emif: AM243x | ||
| * pru_i2s_diagnostic: AM261x, AM263x |
There was a problem hiding this comment.
Remove this as not yet merged
User description
MAJOR UPDATES:
Supported processors: AM243x, AM261x, AM263Px, AM263x, AM62x, AM64x
Supported SDK versions: Refer to https://github.com/TexasInstruments/open-pru/blob/main/docs/release_notes.md
ACADEMIES:
PRU Academy for AM243x at https://dev.ti.com/tirex/explore/node?isTheia=false&node=A__AB.mSUi9ihL.a5hIt1grfw__AM24X-ACADEMY__ZPSnq-h__LATEST PRU Academy for AM64x at https://dev.ti.com/tirex/explore/node?isTheia=false&node=A__AB.mSUi9ihL.a5hIt1grfw__AM64-ACADEMY__WI1KRXP__LATEST
ADDITIONAL UPDATES & BUGFIXES:
Bugfix: release notes > compatible SDKs > v2025.00.00
Add libraries for PRU to communicate with Linux through the RPMsg Inter-Processor Communication (IPC) protocol
Add examples/rpmsg_echo_linux
Add examples/fir
Add github workflows to validate OpenPRU make infrastructure
Bugfix: AM26x projects
DETAILS:
[1]
Officially add AM62x support for building PRU firmware
Add support for AM62x to these existing OpenPRU projects:
[2]
Add support for building PRU firmware that interacts with Linux through the RPMsg Inter-Processor Communication (IPC) protocol
[3]
Adding support for AM243x & AM64x MCU+ SDK 11.1 & 11.2 breaks backwards compatibility with previous AM243x & AM64x MCU+ SDK releases. For more information on building an OpenPRU project with an earlier version of MCU+ SDK, refer to https://github.com/TexasInstruments/open-pru/blob/main/docs/using_older_sdks_with_open_pru.md
This version of OpenPRU does NOT update the AM26x MCU+ build infrastructure. Both v2025.00.00 and v2026.00.00 are only compatible with AM26x MCU+ SDK 10.2. For more information about building an AM26x OpenPRU project with an earlier version of MCU+ SDK, refer to https://github.com/TexasInstruments/open-pru/blob/main/docs/using_older_sdks_with_open_pru.md
PR Type
Documentation
Description
Restructure release notes with v2026.00.00 as primary section
Add AM62x support and Linux RPMsg to v2026.00.00 release notes
Update SDK compatibility table for AM243x & AM64x MCU+ 11.1-11.2
Document new examples: rpmsg_echo_linux, fir, multicore_scheduler
Add guidance for reverting MCU+ SDK 11.1 makefile updates
Diagram Walkthrough
File Walkthrough
release_notes.md
Restructure and expand v2026.00.00 release notesdocs/release_notes.md
with detailed subsections
v2026.00.00
AM243x & AM64x
with descriptions
info
release notes" section
using_older_sdks_with_open_pru.md
Add MCU+ 10.1-11.0 guidance and SDK 11.1 revert instructionsdocs/using_older_sdks_with_open_pru.md
modifications
updates
11.1