How_to_Guides: Enabling protected UEFI variables in U-Boot #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This guide details the process of enabling protected UEFI variables in U-Boot specifically for the J784S4 platforms. Protected UEFI variables offer a secure storage mechanism within the board's eMMC flash, accessible only by authorized software. Signed-off-by: Enric Balletbo i Serra <[email protected]>
eballetbo
requested review from
cshilwant,
StaticRocket,
praneethbajjuri,
uditkumarti,
aniket-l and
VeeruPrudhvi
as code owners
|
New warnings found with rstcheck: |
cshilwant
requested changes
Feb 17, 2025
There was a problem hiding this comment.
Thanks for the PR. The PR doesn't seem to follow the commit message convention mentioned in guidelines - https://github.com/TexasInstruments/processor-sdk-doc/blob/master/CONTRIBUTING.md#commit-formatting
& this is leading the commit check workflow to fail - https://github.com/TexasInstruments/processor-sdk-doc/actions/runs/13306258631?pr=163
|
I assume this will not actually build into the J784 docs without also adding the file to configs/<part_number>/<part_number>_linux_toc.txt? Any other devices that the page should show up for? |
manorit2001
suggested changes
Feb 27, 2025
| make CROSS_COMPILE="$CC32" CROSS_COMPILE64="$CC64" \ | ||
| PLATFORM="$OPTEE_PLATFORM" CFG_ARM64_core=y $OPTEE_EXTRA_ARGS \ | ||
| CFG_RPMB_FS_DEV_ID=0 CFG_REE_FS=n CFG_RPMB_FS=y \ | ||
| CFG_RPMB_WRITE_KEY=y CFG_RPMB_TESTKEY=y \ |
There was a problem hiding this comment.
I see hardcoding CFG_RPMB_TESTKEY=y would not use our HUK at all, we should keep it disabled otherwise we'd always end up programming the test key.
There was a problem hiding this comment.
Also, would be better to just tell the extra configs that are required and point to normal build commands of op-tee?would help in future incase something changes..
| CFG_RPMB_FS_DEV_ID=0 CFG_REE_FS=n CFG_RPMB_FS=y \ | ||
| CFG_RPMB_WRITE_KEY=y CFG_RPMB_TESTKEY=y \ | ||
| CFG_STMM_PATH=BL32_AP_MM.fd \ | ||
| CFG_CORE_HEAP_SIZE=524288 CFG_CORE_DYN_SHM=y CFG_SCTLR_ALIGNMENT_CHECK=n \ |
There was a problem hiding this comment.
Why are we clearing alignment check btw? Could you explain the various flags as to why they are required
bryanbrattlof
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This guide details the process of enabling protected UEFI variables in U-Boot specifically for the J784S4 platforms. Protected UEFI variables offer a secure storage mechanism within the board's eMMC flash, accessible only by authorized software.