Ethetnet boot documentation #260
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chintan013
requested review from
cshilwant,
StaticRocket,
praneethbajjuri,
uditkumarti,
aniket-l and
VeeruPrudhvi
as code owners
github-actions
bot
assigned bryanbrattlof, devarsht, jmenti, praneethbajjuri, r-vignesh and uditkumarti
github-actions
bot
requested review from
bryanbrattlof,
devarsht,
jmenti and
r-vignesh
|
@danish-ti to review |
Update Ethernet boot documentation with device specific config snippet to avoid adding the same code-block for every device. Also add config variables of the device for which documentation already exist, AM64X and AM62X. Signed-off-by: Chintan Vankar <[email protected]>
Ethernet boot support has been added to J722s SoC, add documentation for the same. Signed-off-by: Chintan Vankar <[email protected]>
Ethernet boot support has been added to AM62px SoC, add documentation for the same. Signed-off-by: Chintan Vankar <[email protected]>
Ethernet boot support has been added to J721s2 SoC, add documentation for the same. Signed-off-by: Chintan Vankar <[email protected]>
StaticRocket
reviewed
Apr 9, 2025
|
|
||
| If using ISC dhcpd an example host entry would look like this: | ||
|
|
||
| .. code-block:: text | ||
| .. parsed-literal:: |
There was a problem hiding this comment.
Alright, this can kind of work, but there are issues.
-
Ifconfig is essentially a mask. This section will still be parsed on other platforms and will result in a replacement error if they do not have the replacement definition. Right now you've defined the variable for all machines that include this file, so it's fine. You can remove that ifconfig mask as it's not doing anything.
-
Parsed literals will not be escaped. Any valid RST will be parsed. This example is fine right now. Any additions will have to take this into account.
This is why I was pushing more towards defining a table and user template here. I'll let others weigh in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.