Skip to content

fix(HSR_Offload): changed introduction.rst #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kathrynsuraya
Copy link

Replaces introduction with more information on HSR offloading

Copy link

New warnings found with rstcheck:

source/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/HSR_Offload.rst:21: (WARNING/2) Explicit markup ends without a blank line; unexpected unindent.

Copy link
Member

@StaticRocket StaticRocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two requested changes, and please make sure to change the commit message to match the styling outlined in the contribution guide: https://github.com/TexasInstruments/processor-sdk-doc/blob/master/CONTRIBUTING.md

Otherwise this is a much more thorough introduction to HSR. Thanks

Offloading is the process of transferring tasks away from the CPU to another processing unit. In the case of the AM64x Sitara Processor,
HSR tasks can be offloaded from the A53 cores to the PRU_ICSSG.

.. rubric:: **Linux HSR Offload Support**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a newline after a directive.

Comment on lines +22 to +25
• hsr-fwd-offload: For forwarding HSR frames one port to another i.e. port-to-port forwarding
• hsr-dup-offload: Duplicate the outgoing HSR frame
• hsr-tag-ins-offload: Unique tag to identify HSR frames
• hsr-tag-rm-offload: Removes the HSR tags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hsr-fwd-offload: For forwarding HSR frames one port to another i.e. port-to-port forwarding
hsr-dup-offload: Duplicate the outgoing HSR frame
hsr-tag-ins-offload: Unique tag to identify HSR frames
hsr-tag-rm-offload: Removes the HSR tags
- hsr-fwd-offload: For forwarding HSR frames one port to another i.e. port-to-port forwarding
- hsr-dup-offload: Duplicate the outgoing HSR frame
- hsr-tag-ins-offload: Unique tag to identify HSR frames
- hsr-tag-rm-offload: Removes the HSR tags

@StaticRocket
Copy link
Member

Linking with previous duplicate PRs:
Duplicate of #160
Duplicate of #207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants