-
Notifications
You must be signed in to change notification settings - Fork 61
chore(j7-family): finally split the j7 family #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
StaticRocket
wants to merge
1
commit into
TexasInstruments:master
Choose a base branch
from
StaticRocket:chore/fix-j7family
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore(j7-family): finally split the j7 family #293
StaticRocket
wants to merge
1
commit into
TexasInstruments:master
from
StaticRocket:chore/fix-j7family
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to be convenient, but ultimately there's no guarantee a device stays part of a family or not. On top of that, there should be no reason for Jacinto to be special here. Finally split the family so we can remove some exceptions to general rules other platforms follow. Signed-off-by: Randolph Sapp <[email protected]>
New warnings found with rstcheck:
|
+ @sinha-shreyash @ankur-ti @uditkumarti @aniket-l for reviews |
@StaticRocket
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be convenient, but ultimately there's no guarantee a device stays part of a family or not. On top of that, there should be no reason for Jacinto to be special here. Finally split the family so we can remove some exceptions to general rules other platforms follow.
This makes config patterns obvious. I hope to reduce more of this logic later.