Skip to content

fix(OP-TEE): configs: Fix OPTEE_TARGET_FLAVOUR #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manorit2001
Copy link
Contributor

This is wrong for some platforms, update them to fix the builds.

This is wrong for some platforms, update them to fix the builds.

Reported-by: Diwakar Dhyani <[email protected]>
Signed-off-by: Manorit Chawdhry <[email protected]>
@manorit2001 manorit2001 force-pushed the optee-fix-platform branch from ca15f91 to 0071fd4 Compare May 19, 2025 10:37
@praneethbajjuri
Copy link
Collaborator

Adding @bryanbrattlof as well for review.
Is this change necessary after pulling optee update that contains this OP-TEE/optee_os#7377 ?

@bryanbrattlof
Copy link
Collaborator

bryanbrattlof commented May 19, 2025

ah yeah I didn't notice the Jacinto chips had the same issue 🫤 but this looks great 👍

62L: https://github.com/TexasInstruments/processor-sdk-doc/blob/master/configs/AM62LX/AM62LX_linux_config.txt#L27
62P: https://github.com/TexasInstruments/processor-sdk-doc/blob/master/configs/AM62PX/AM62PX_linux_config.txt#L27

are still a little messed up but we can fix that later

@praneethbajjuri
Copy link
Collaborator

are still a little messed up but we can fix that later

Or wait till OPTEE sha/tag is updated that contains the fix and no need to update doc after that.

@manorit2001
Copy link
Contributor Author

are still a little messed up but we can fix that later

Or wait till OPTEE sha/tag is updated that contains the fix and no need to update doc after that.

I would still recommend to not make it the norm to add such new cosmetic platforms btw, since it's already in it's fine but please fix the documentation only next time onwards as otherwise it can become a mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants