test(modal): increase pauses in flaky test #6116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like `test_modal_pop_screen()` has started being flaky in CI. Increase the initial pause to ensure the footer is fully composed when clicked. This seemed to be the fix for a similar flaky test in Textualize#6032.
After increasing the pause, this test is still flaky in CI. Try adding a `wait_for_refresh` as well, the same as the fix for a similar flaky test in Textualize#6116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
test_modal_pop_screen()has started being flaky in CI.Increase the initial pause to ensure the footer is fully composed when clicked. This seemed to be the fix for a similar flaky test in #6032.
Please review the following checklist.