feat: support archive_override for ORFS pin#719
Merged
Conversation
bzlmod resolution of bazel-orfs fails inside the maintainers organization because direct git access to OpenROAD-flow-scripts is blocked while the GitHub /archive/<sha>.tar.gz endpoint is reachable. Switch the ORFS pin in MODULE.bazel from git_override to archive_override (HTTPS tarball with SRI integrity), and teach bump.py to update urls/integrity/strip_prefix in archive_override blocks. bump.py auto-detects which override style is in use, so existing git_override-based pinnings (the historical default and what openroad/qt-bazel still use here) continue to work unchanged. Also bumps openroad/orfs/qt-bazel/yosys via the bump tool — the bump itself was the verification that the new code path works end-to-end. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]> Signed-off-by: Øyvind Harboe <[email protected]>
oharboe
added a commit
to oharboe/OpenROAD-flow-scripts
that referenced
this pull request
May 8, 2026
Bump bazel-orfs to b1ceeb28 (head of The-OpenROAD-Project/bazel-orfs#719, "feat: support archive_override for ORFS pin"). All four bazel-orfs patches carried in this PR are upstreamed there: * 0001-stages-register-bazel-injected-vars-in-validator.patch * 0002-synth_partition-fix-SYNTH_SKIP_KEEP-truthy-check.patch * 0003-synth_partition-parse-kept_modules-json-without-greedy-sed.patch * 0004-orfs_design-forward-user_arguments-to-orfs_flow.patch so the patch files and the bazel/bazel-orfs-patches/ directory are removed. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]> Signed-off-by: Øyvind Harboe <[email protected]>
The self-archive.MODULE.bazel fixture was missing from the BUILD data list, causing 7 FileNotFoundError failures in CI. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Øyvind Harboe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
bzlmod resolution of `bazel-orfs` fails inside the maintainers organization because direct `git clone` of OpenROAD-flow-scripts is blocked there. The GitHub `/archive/.tar.gz` endpoint is reachable, so the fix is to pin ORFS via tarball.
`bump.py` is the canonical updater (`bazelisk run @bazel-orfs//:bump`), so it has to learn the archive_override shape to keep the pin live.
Test plan
🤖 Generated with Claude Code