Skip to content

fix(gitlab): add null check for target_file in publish_code_suggestions #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gvago wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

fix(gitlab): add null check for target_file in publish_code_suggestions #2316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pr_agent/git_providers/gitlab_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,6 +673,9 @@ def publish_code_suggestions(self, code_suggestions: list) -> bool:
if file.filename == relevant_file:
target_file = file
break
if target_file is None:
get_logger().warning(f"Skipping suggestion: file '{relevant_file}' not found in diff")
continue
range = relevant_lines_end - relevant_lines_start # no need to add 1
body = body.replace('```suggestion', f'```suggestion:-0+{range}')
lines = target_file.head_file.splitlines()
Expand Down
Loading