Skip to content

refactor(heap): remove redundant TypeVar in Heap #15504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iosayin wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −3
Open

refactor(heap): remove redundant TypeVar in Heap #15504

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11e06fd
refactor(heap): remove redundant TypeVar in Heap
iosayin Oct 5, 2026
958f170
refactor(heap): revert Comparable.__gt__ signature to self: T, other: T
iosayin Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions data_structures/heap/heap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,15 @@

from abc import abstractmethod
from collections.abc import Iterable
from typing import Protocol, TypeVar
from typing import Protocol


class Comparable(Protocol):
@abstractmethod
def __gt__(self: T, other: T, /) -> bool:
def __gt__(self, other: object, /) -> bool:

@cclauss cclauss Oct 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change. We want both self and other to be of type T.

pass


T = TypeVar("T", bound=Comparable)


class Heap[T: Comparable]:
"""A Max Heap Implementation

Expand Down Expand Up @@ -253,7 +250,7 @@
]:
print(f"unsorted array: {unsorted}")

heap: Heap[int] = Heap()

Check failure on line 253 in data_structures/heap/heap.py

View workflow job for this annotation

GitHub Actions / ty

ty (invalid-type-arguments) 

data_structures/heap/heap.py:253:20: invalid-type-arguments: Type `int` is not assignable to upper bound `Comparable` of type variable `T@Heap`
  data_structures/heap/heap.py:14:12: Type variable defined here
  info: type `int` is not assignable to protocol `Comparable`
  info: └── protocol member `__gt__` is incompatible
  info:     └── parameter `other` has an incompatible type: `object` is not assignable to `int`
heap.build_max_heap(unsorted)
print(f"after build heap: {heap}")

Expand Down
Loading