Skip to content

Added simplicial_polytopic_number.rs and rising_factorial.rs to /src/… #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WinterPancake
Copy link

…math

Pull Request Template

Description

simplcial_polytopic_number.rs is meant to replace triangular_number.rs and tetrahedral_number.rs.

I added simplicial_polytopic_number.rs and rising_factorial.rs to /src/math/.
Simplicial polytopic numbers are a family of sequences of figurate numbers corresponding to the d-dimensionsal simplex for each dimensional simplex for each dimension d, where d is a nonnegative integer.

Rising factorials are defined as the polynomial
(x)_n = x(x + 1)(x + 2)...(x + n - 1)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or
try to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (99e33d1) to head (2da705f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #898      +/-   ##
==========================================
- Coverage   95.32%   95.28%   -0.05%     
==========================================
  Files         319      321       +2     
  Lines       20807    20830      +23     
==========================================
+ Hits        19834    19847      +13     
- Misses        973      983      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants