Add ASI PLC control logic docs and images#1204
Conversation
Add new ASI Control Logic guide (docs/source/02_user_guide/01_supported_hardware/asi_logic.rst) describing Z-stack and continuous acquisition PLC workflows and sequencing. Include three diagrams (plc_control_loop.png, plc_control_loop_2.png, plc_continuous.png) and update daq.rst to link to the new ASI logic section for reference.
There was a problem hiding this comment.
Pull request overview
Adds documentation describing ASI Tiger PLC control logic (Z-stack and continuous acquisition) and links it from the DAQ hardware guide so users can understand how ASI timing is implemented within navigate.
Changes:
- Added a new “ASI Control Logic” documentation page with diagrams for Z-stack and continuous acquisition workflows.
- Linked the DAQ hardware guide’s Altair/ASI section to the new ASI control-logic documentation.
- Added a new PLC diagram image (
plc_continuous.png) for the continuous-acquisition section.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/source/images/plc_continuous.png | Adds the continuous-acquisition PLC diagram referenced by the new ASI logic page. |
| docs/source/02_user_guide/01_supported_hardware/daq.rst | Adds a cross-reference from the ASI/Altair setup section to the ASI PLC logic documentation. |
| docs/source/02_user_guide/01_supported_hardware/asi_logic.rst | New documentation page describing ASI Tiger PLC trigger sequencing with included diagrams. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
|
||
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1204 +/- ##
===========================================
+ Coverage 63.64% 63.65% +0.01%
===========================================
Files 189 189
Lines 26029 26029
===========================================
+ Hits 16565 16568 +3
+ Misses 9464 9461 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
joelaugustine099
left a comment
There was a problem hiding this comment.
Looks good now
Add new ASI Control Logic guide (docs/source/02_user_guide/01_supported_hardware/asi_logic.rst) describing Z-stack and continuous acquisition PLC workflows and sequencing. Include three diagrams (plc_control_loop.png, plc_control_loop_2.png, plc_continuous.png) and update daq.rst to link to the new ASI logic section for reference.