Skip to content

Add ASI PLC control logic docs and images#1204

Merged
AdvancedImagingUTSW merged 3 commits intodevelopfrom
logic-docs
Mar 17, 2026
Merged

Add ASI PLC control logic docs and images#1204
AdvancedImagingUTSW merged 3 commits intodevelopfrom
logic-docs

Conversation

@AdvancedImagingUTSW
Copy link
Collaborator

Add new ASI Control Logic guide (docs/source/02_user_guide/01_supported_hardware/asi_logic.rst) describing Z-stack and continuous acquisition PLC workflows and sequencing. Include three diagrams (plc_control_loop.png, plc_control_loop_2.png, plc_continuous.png) and update daq.rst to link to the new ASI logic section for reference.

Add new ASI Control Logic guide (docs/source/02_user_guide/01_supported_hardware/asi_logic.rst) describing Z-stack and continuous acquisition PLC workflows and sequencing. Include three diagrams (plc_control_loop.png, plc_control_loop_2.png, plc_continuous.png) and update daq.rst to link to the new ASI logic section for reference.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds documentation describing ASI Tiger PLC control logic (Z-stack and continuous acquisition) and links it from the DAQ hardware guide so users can understand how ASI timing is implemented within navigate.

Changes:

  • Added a new “ASI Control Logic” documentation page with diagrams for Z-stack and continuous acquisition workflows.
  • Linked the DAQ hardware guide’s Altair/ASI section to the new ASI control-logic documentation.
  • Added a new PLC diagram image (plc_continuous.png) for the continuous-acquisition section.

Reviewed changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated 2 comments.

File Description
docs/source/images/plc_continuous.png Adds the continuous-acquisition PLC diagram referenced by the new ASI logic page.
docs/source/02_user_guide/01_supported_hardware/daq.rst Adds a cross-reference from the ASI/Altair setup section to the ASI PLC logic documentation.
docs/source/02_user_guide/01_supported_hardware/asi_logic.rst New documentation page describing ASI Tiger PLC trigger sequencing with included diagrams.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 57 to 58


@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.65%. Comparing base (d4a276a) to head (221f7a4).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1204      +/-   ##
===========================================
+ Coverage    63.64%   63.65%   +0.01%     
===========================================
  Files          189      189              
  Lines        26029    26029              
===========================================
+ Hits         16565    16568       +3     
+ Misses        9464     9461       -3     
Flag Coverage Δ
unittests 63.65% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

joelaugustine099 and others added 2 commits March 17, 2026 15:28
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Collaborator

@joelaugustine099 joelaugustine099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@AdvancedImagingUTSW AdvancedImagingUTSW merged commit a197d21 into develop Mar 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants