Add dither support to remote focus waveforms#1205
Closed
AdvancedImagingUTSW wants to merge 1 commit intodevelopfrom
Closed
Add dither support to remote focus waveforms#1205AdvancedImagingUTSW wants to merge 1 commit intodevelopfrom
AdvancedImagingUTSW wants to merge 1 commit intodevelopfrom
Conversation
Introduce dither amplitude/frequency parameters for remote-focus channels and wire them through config, UI, model and tests.
- config: add default string keys ("dither_amplitude", "dither_frequency") in verify_waveform_constants and include entries in waveform_constants.yml.
- view: add Dither Amplitude and Dither Frequency inputs to WaveformParameterPopupWindow.
- controller: WaveformPopupController now tracks dither variables, traces, validation, UI configuration, and stores values with existing amplitude/offset settings; enables/disables dither controls when live mode toggles.
- model: RemoteFocusBase gains robust parsing helper get_remote_focus_setting to coerce and validate string inputs, reads dither settings, and if both dither amplitude and frequency are >0 overlays a triangle dither waveform onto the remote-focus waveform.
- waveforms: add triangle_wave() utility used to generate the dither signal.
- tests: update existing tests to expect the new keys and widget values, add test to ensure dither is applied after smoothing, and add a waveform-tab test to verify the updated remote-focus waveform is plotted.
Also includes related minor refactors and logging updates for remote-focus setting changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1205 +/- ##
===========================================
+ Coverage 63.64% 63.93% +0.28%
===========================================
Files 189 189
Lines 26029 26085 +56
===========================================
+ Hits 16567 16677 +110
+ Misses 9462 9408 -54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce dither amplitude/frequency parameters for remote-focus channels and wire them through config, UI, model and tests.
Also includes related minor refactors and logging updates for remote-focus setting changes.