Close dense-analysis#3325 - Apply new formatting where possible

.gitignore

@@ -1,11 +1,12 @@
 !.editorconfig
 *.obj
+*.pyc
 # Ignore all hidden files everywhere.
 # Use `git add -f` to add hidden files.
 .*
-__pycache__
-*.pyc
 /doc/tags
 /init.vim
 /test/ale-info-test-file
+/vader_output
+__pycache__
 tags

ale_linters/ada/gcc.vim

@@ -18,7 +18,7 @@ function! ale_linters#ada#gcc#GetCommand(buffer) abort
     " -gnatc: Check syntax and semantics only (no code generation attempted)
     return '%e -x ada -c -gnatc'
     \   . ' -o ' . ale#Escape(l:out_file)
-    \   . ' -I ' . ale#Escape(fnamemodify(bufname(a:buffer), ':p:h'))
+    \   . ' -I %s:h'
     \   . ale#Pad(ale#Var(a:buffer, 'ada_gcc_options'))
     \   . ' %t'
 endfunction

ale_linters/asm/gcc.vim

@@ -9,7 +9,7 @@ function! ale_linters#asm#gcc#GetCommand(buffer) abort
     " -fsyntax-only doesn't catch everything.
     return '%e -x assembler'
     \   . ' -o ' . g:ale#util#nul_file
-    \   . '-iquote ' . ale#Escape(fnamemodify(bufname(a:buffer), ':p:h'))
+    \   . '-iquote %s:h'
     \   . ' ' . ale#Var(a:buffer, 'asm_gcc_options') . ' -'
 endfunction
 

ale_linters/c/cc.vim

@@ -38,7 +38,7 @@ function! ale_linters#c#cc#GetCommand(buffer, output) abort
     " -fsyntax-only doesn't catch everything.
     return '%e -S -x c'
     \   . ' -o ' . g:ale#util#nul_file
-    \   . ' -iquote ' . ale#Escape(fnamemodify(bufname(a:buffer), ':p:h'))
+    \   . ' -iquote %s:h'
     \   . ale#Pad(l:cflags)
     \   . ale#Pad(l:ale_flags) . ' -'
 endfunction

ale_linters/cpp/cc.vim

@@ -38,7 +38,7 @@ function! ale_linters#cpp#cc#GetCommand(buffer, output) abort
     " -fsyntax-only doesn't catch everything.
     return '%e -S -x c++'
     \   . ' -o ' . g:ale#util#nul_file
-    \   . ' -iquote ' . ale#Escape(fnamemodify(bufname(a:buffer), ':p:h'))
+    \   . ' -iquote %s:h'
     \   . ale#Pad(l:cflags)
     \   . ale#Pad(l:ale_flags) . ' -'
 endfunction

ale_linters/cuda/nvcc.vim

@@ -5,9 +5,6 @@ call ale#Set('cuda_nvcc_executable', 'nvcc')
 call ale#Set('cuda_nvcc_options', '-std=c++11')
 
 function! ale_linters#cuda#nvcc#GetCommand(buffer) abort
-    " Unused: use ale#util#nul_file
-    " let l:output_file = ale#util#Tempname() . '.ii'
-    " call ale#command#ManageFile(a:buffer, l:output_file)
     return '%e -cuda'
     \   . ale#Pad(ale#c#IncludeOptions(ale#c#FindLocalHeaderPaths(a:buffer)))
     \   . ale#Pad(ale#Var(a:buffer, 'cuda_nvcc_options'))

ale_linters/eruby/ruumba.vim

@@ -11,7 +11,7 @@ function! ale_linters#eruby#ruumba#GetCommand(buffer) abort
     return ale#ruby#EscapeExecutable(l:executable, 'ruumba')
     \   . ' --format json --force-exclusion '
     \   . ale#Var(a:buffer, 'eruby_ruumba_options')
-    \   . ' --stdin ' . ale#Escape(expand('#' . a:buffer . ':p'))
+    \   . ' --stdin %s'
 endfunction
 
 function! ale_linters#eruby#ruumba#Handle(buffer, lines) abort

ale_linters/nasm/nasm.vim

@@ -7,10 +7,9 @@ call ale#Set('nasm_nasm_options', '')
 function! ale_linters#nasm#nasm#GetCommand(buffer) abort
     " Note that NASM requires a trailing slash for the -I option.
     let l:separator = has('win32') ? '\' : '/'
-    let l:path = fnamemodify(bufname(a:buffer), ':p:h') . l:separator
     let l:output_null = has('win32') ? 'NUL' : '/dev/null'
 
-    return '%e -X gnu -I ' . ale#Escape(l:path)
+    return '%e -X gnu -I %s:h' . l:separator
     \   . ale#Pad(ale#Var(a:buffer, 'nasm_nasm_options'))
     \   . ' %s'
     \   . ' -o ' . l:output_null

ale_linters/objc/clang.vim

@@ -10,7 +10,7 @@ function! ale_linters#objc#clang#GetCommand(buffer) abort
     " -iquote with the directory the file is in makes #include work for
     "  headers in the same directory.
     return 'clang -S -x objective-c -fsyntax-only '
-    \   . '-iquote ' . ale#Escape(fnamemodify(bufname(a:buffer), ':p:h'))
+    \   . '-iquote %s:h'
     \   . ' ' . ale#Var(a:buffer, 'objc_clang_options') . ' -'
 endfunction
 

ale_linters/objcpp/clang.vim

@@ -10,7 +10,7 @@ function! ale_linters#objcpp#clang#GetCommand(buffer) abort
     " -iquote with the directory the file is in makes #include work for
     "  headers in the same directory.
     return 'clang++ -S -x objective-c++ -fsyntax-only '
-    \   . '-iquote ' . ale#Escape(fnamemodify(bufname(a:buffer), ':p:h'))
+    \   . '-iquote %s:h'
     \   . ' ' . ale#Var(a:buffer, 'objcpp_clang_options') . ' -'
 endfunction
 

ale_linters/pyrex/cython.vim

@@ -6,9 +6,7 @@ call ale#Set('pyrex_cython_executable', 'cython')
 call ale#Set('pyrex_cython_options', '--warning-extra')
 
 function! ale_linters#pyrex#cython#GetCommand(buffer) abort
-    let l:local_dir = ale#Escape(fnamemodify(bufname(a:buffer), ':p:h'))
-
-    return '%e --working ' . l:local_dir . ' --include-dir ' . l:local_dir
+    return '%e --working %s:h --include-dir %s:h'
     \   . ale#Pad(ale#Var(a:buffer, 'pyrex_cython_options'))
     \   . ' --output-file ' . g:ale#util#nul_file . ' %t'
 endfunction

ale_linters/python/pydocstyle.vim

@@ -16,17 +16,15 @@ function! ale_linters#python#pydocstyle#GetExecutable(buffer) abort
 endfunction
 
 function! ale_linters#python#pydocstyle#GetCommand(buffer) abort
-    let l:dir = fnamemodify(bufname(a:buffer), ':p:h')
     let l:executable = ale_linters#python#pydocstyle#GetExecutable(a:buffer)
-
     let l:exec_args = l:executable =~? 'pipenv$'
     \   ? ' run pydocstyle'
     \   : ''
 
-    return ale#path#CdString(l:dir)
+    return ale#path#BufferCdString(a:buffer)
     \   . ale#Escape(l:executable) . l:exec_args
-    \   . ' ' . ale#Var(a:buffer, 'python_pydocstyle_options')
-    \   . ' ' . ale#Escape(fnamemodify(bufname(a:buffer), ':p:t'))
+    \   . ale#Pad(ale#Var(a:buffer, 'python_pydocstyle_options'))
+    \   . ' %s:t'
 endfunction
 
 function! ale_linters#python#pydocstyle#Handle(buffer, lines) abort

ale_linters/ruby/rubocop.vim

@@ -10,7 +10,7 @@ function! ale_linters#ruby#rubocop#GetCommand(buffer) abort
     return ale#ruby#EscapeExecutable(l:executable, 'rubocop')
     \   . ' --format json --force-exclusion '
     \   . ale#Var(a:buffer, 'ruby_rubocop_options')
-    \   . ' --stdin ' . ale#Escape(expand('#' . a:buffer . ':p'))
+    \   . ' --stdin %s'
 endfunction
 
 function! ale_linters#ruby#rubocop#GetType(severity) abort

ale_linters/ruby/standardrb.vim

@@ -11,7 +11,7 @@ function! ale_linters#ruby#standardrb#GetCommand(buffer) abort
     return ale#ruby#EscapeExecutable(l:executable, 'standardrb')
     \   . ' --format json --force-exclusion '
     \   . ale#Var(a:buffer, 'ruby_standardrb_options')
-    \   . ' --stdin ' . ale#Escape(expand('#' . a:buffer . ':p'))
+    \   . ' --stdin %s'
 endfunction
 
 " standardrb is based on RuboCop so the callback is the same

autoload/ale/c.vim

@@ -501,10 +501,10 @@ endfunction
 
 function! ale#c#GetMakeCommand(buffer) abort
     if s:CanParseMakefile(a:buffer)
-        let l:makefile_path = ale#path#FindNearestFile(a:buffer, 'Makefile')
+        let l:path = ale#path#FindNearestFile(a:buffer, 'Makefile')
 
-        if !empty(l:makefile_path)
-            return 'cd '. fnamemodify(l:makefile_path, ':p:h') . ' && make -n'
+        if !empty(l:path)
+            return ale#path#CdString(fnamemodify(l:path, ':h')) . 'make -n'
         endif
     endif
 

autoload/ale/fixers/ocamlformat.vim

@@ -5,14 +5,13 @@ call ale#Set('ocaml_ocamlformat_executable', 'ocamlformat')
 call ale#Set('ocaml_ocamlformat_options', '')
 
 function! ale#fixers#ocamlformat#Fix(buffer) abort
-    let l:filename = expand('#' . a:buffer . ':p')
     let l:executable = ale#Var(a:buffer, 'ocaml_ocamlformat_executable')
     let l:options = ale#Var(a:buffer, 'ocaml_ocamlformat_options')
 
     return {
     \   'command': ale#Escape(l:executable)
     \       . (empty(l:options) ? '' : ' ' . l:options)
-    \       . ' --name=' . ale#Escape(l:filename)
+    \       . ' --name=%s'
     \       . ' -'
     \}
 endfunction

autoload/ale/fixers/rubocop.vim

@@ -29,8 +29,7 @@ function! ale#fixers#rubocop#GetCommand(buffer) abort
     \   . (!empty(l:config) ? ' --config ' . ale#Escape(l:config) : '')
     \   . (!empty(l:options) ? ' ' . l:options : '')
     \   . (l:auto_correct_all ? ' --auto-correct-all' : ' --auto-correct')
-    \   . ' --force-exclusion --stdin '
-    \   . ale#Escape(expand('#' . a:buffer . ':p'))
+    \   . ' --force-exclusion --stdin %s'
 endfunction
 
 function! ale#fixers#rubocop#Fix(buffer) abort

test/command_callback/test_ada_gcc_command_callbacks.vader

@@ -18,27 +18,25 @@ After:
   call ale#assert#TearDownLinterTest()
 
 Execute(The executable should be configurable):
-
   AssertLinter 'gcc',
   \ ale#Escape('gcc') . ' -x ada -c -gnatc'
   \ . ' -o ' . b:out_file
-  \ . ' -I ' . ale#Escape(getcwd())
+  \ . ' -I %s:h'
   \ . ' -gnatwa -gnatq %t'
 
   let b:ale_ada_gcc_executable = 'foo'
 
   AssertLinter 'foo',
   \ ale#Escape('foo') . ' -x ada -c -gnatc'
   \ . ' -o ' . b:out_file
-  \ . ' -I ' . ale#Escape(getcwd())
+  \ . ' -I %s:h'
   \ . ' -gnatwa -gnatq %t'
 
 Execute(The options should be configurable):
-
   let g:ale_ada_gcc_options = '--foo --bar'
 
   AssertLinter 'gcc',
   \ ale#Escape('gcc') . ' -x ada -c -gnatc'
   \ . ' -o ' . b:out_file
-  \ . ' -I ' . ale#Escape(getcwd())
+  \ . ' -I %s:h'
   \ . ' --foo --bar %t'

test/command_callback/test_asm_gcc_command_callbacks.vader

@@ -3,7 +3,7 @@ Before:
   call ale#test#SetFilename('test.cpp')
   let b:command_tail = ' -x assembler'
   \   . ' -o ' . (has('win32') ? 'nul': '/dev/null')
-  \   . '-iquote ' . ale#Escape(g:dir)
+  \   . '-iquote %s:h'
   \   . ' -Wall -'
 
 After:

test/command_callback/test_c_cc_command_callbacks.vader

@@ -23,7 +23,7 @@ Before:
 
   let b:command_tail = ' -S -x c'
   \   . ' -o ' . (has('win32') ? 'nul': '/dev/null')
-  \   . ' -iquote ' . ale#Escape(getcwd())
+  \   . ' -iquote %s:h'
   \   . ' -std=c11 -Wall -'
 
 After:

test/command_callback/test_c_import_paths.vader

@@ -43,7 +43,7 @@ Execute(The C cc linter should include 'include' directories for projects with a
   AssertLinter 'gcc',
   \ ale#Escape('gcc')
   \   . ' -S -x c -o ' . (has('win32') ? 'nul': '/dev/null')
-  \   . ' -iquote ' . ale#Escape(ale#path#Simplify(g:dir .  '/../test_c_projects/makefile_project/subdir'))
+  \   . ' -iquote %s:h'
   \   . ' -I' . ale#Escape(ale#path#Simplify(g:dir .  '/../test_c_projects/makefile_project/include'))
   \   . ' -'
 
@@ -55,7 +55,7 @@ Execute(The C cc linter should include 'include' directories for projects with a
   AssertLinter 'gcc',
   \ ale#Escape('gcc')
   \   . ' -S -x c -o ' . (has('win32') ? 'nul': '/dev/null')
-  \   . ' -iquote ' . ale#Escape(ale#path#Simplify(g:dir .  '/../test_c_projects/configure_project/subdir'))
+  \   . ' -iquote %s:h'
   \   . ' -I' . ale#Escape(ale#path#Simplify(g:dir .  '/../test_c_projects/configure_project/include'))
   \   . ' -'
 
@@ -67,7 +67,7 @@ Execute(The C cc linter should include root directories for projects with .h fil
   AssertLinter 'gcc',
   \ ale#Escape('gcc')
   \   . ' -S -x c -o ' . (has('win32') ? 'nul': '/dev/null')
-  \   . ' -iquote ' . ale#Escape(ale#path#Simplify(g:dir .  '/../test_c_projects/h_file_project/subdir'))
+  \   . ' -iquote %s:h'
   \   . ' -I' . ale#Escape(ale#path#Simplify(g:dir .  '/../test_c_projects/h_file_project'))
   \   . ' -'
 
@@ -79,7 +79,7 @@ Execute(The C cc linter should include root directories for projects with .hpp f
   AssertLinter 'gcc',
   \ ale#Escape('gcc')
   \   . ' -S -x c -o ' . (has('win32') ? 'nul': '/dev/null')
-  \   . ' -iquote ' . ale#Escape(ale#path#Simplify(g:dir .  '/../test_c_projects/hpp_file_project/subdir'))
+  \   . ' -iquote %s:h'
   \   . ' -I' . ale#Escape(ale#path#Simplify(g:dir .  '/../test_c_projects/hpp_file_project'))
   \   . ' -'
 
@@ -101,7 +101,7 @@ Execute(The C++ cc linter should include 'include' directories for projects with
   AssertLinter 'gcc',
   \   ale#Escape('gcc')
   \   . ' -S -x c++ -o ' . (has('win32') ? 'nul': '/dev/null')
-  \   . ' -iquote ' . ale#Escape(ale#path#Simplify(g:dir .  '/../test_c_projects/makefile_project/subdir'))
+  \   . ' -iquote %s:h'
   \   . ' -I' . ale#Escape(ale#path#Simplify(g:dir .  '/../test_c_projects/makefile_project/include'))
   \   . ' -'
 
@@ -113,7 +113,7 @@ Execute(The C++ cc linter should include 'include' directories for projects with
   AssertLinter 'gcc',
   \   ale#Escape('gcc')
   \   . ' -S -x c++ -o ' . (has('win32') ? 'nul': '/dev/null')
-  \   . ' -iquote ' . ale#Escape(ale#path#Simplify(g:dir .  '/../test_c_projects/configure_project/subdir'))
+  \   . ' -iquote %s:h'
   \   . ' -I' . ale#Escape(ale#path#Simplify(g:dir .  '/../test_c_projects/configure_project/include'))
   \   . ' -'
 
@@ -125,7 +125,7 @@ Execute(The C++ cc linter should include root directories for projects with .h f
   AssertLinter 'gcc',
   \   ale#Escape('gcc')
   \   . ' -S -x c++ -o ' . (has('win32') ? 'nul': '/dev/null')
-  \   . ' -iquote ' . ale#Escape(ale#path#Simplify(g:dir .  '/../test_c_projects/h_file_project/subdir'))
+  \   . ' -iquote %s:h'
   \   . ' -I' . ale#Escape(ale#path#Simplify(g:dir .  '/../test_c_projects/h_file_project'))
   \   . ' -'
 
@@ -137,7 +137,7 @@ Execute(The C++ cc linter should include root directories for projects with .hpp
   AssertLinter 'gcc',
   \   ale#Escape('gcc')
   \   . ' -S -x c++ -o ' . (has('win32') ? 'nul': '/dev/null')
-  \   . ' -iquote ' . ale#Escape(ale#path#Simplify(g:dir .  '/../test_c_projects/hpp_file_project/subdir'))
+  \   . ' -iquote %s:h'
   \   . ' -I' . ale#Escape(ale#path#Simplify(g:dir .  '/../test_c_projects/hpp_file_project'))
   \   . ' -'
 

test/command_callback/test_cpp_gcc_command_callbacks.vader → test/command_callback/test_cpp_cc_command_callbacks.vader

@@ -23,7 +23,7 @@ Before:
 
   let b:command_tail = ' -S -x c++'
   \   . ' -o ' . (has('win32') ? 'nul': '/dev/null')
-  \   . ' -iquote ' . ale#Escape(getcwd())
+  \   . ' -iquote %s:h'
   \   . ' -std=c++14 -Wall -'
 
 After:

test/command_callback/test_nasm_nasm_command_callbacks.vader

@@ -2,9 +2,9 @@ Before:
   call ale#assert#SetUpLinterTest('nasm', 'nasm')
 
   let b:command_tail =
-  \ ' -X gnu -I ' . ale#Escape(getcwd() . (has('win32') ? '\' : '/')) . ' %s -o ' . (has('win32') ? 'NUL' : '/dev/null')
+  \ ' -X gnu -I %s:h' . (has('win32') ? '\' : '/') . ' %s -o ' . (has('win32') ? 'NUL' : '/dev/null')
   let b:command_tail_opt =
-  \ ' -X gnu -I ' . ale#Escape(getcwd() . (has('win32') ? '\' : '/')) . ' -w+orphan-labels %s -o ' . (has('win32') ? 'NUL' : '/dev/null')
+  \ ' -X gnu -I %s:h' . (has('win32') ? '\' : '/') . ' -w+orphan-labels %s -o ' . (has('win32') ? 'NUL' : '/dev/null')
 
 After:
   unlet! b:command_tail
@@ -23,7 +23,8 @@ Execute(The options should be configurable):
   let b:ale_nasm_nasm_options = '-w-macro-params'
 
   AssertLinter 'nasm', ale#Escape('nasm')
-  \ . ' -X gnu -I ' . ale#Escape(getcwd() . (has('win32') ? '\' : '/')) . ' -w-macro-params %s -o ' . (has('win32') ? 'NUL' : '/dev/null')
+  \ . ' -X gnu -I %s:h' . (has('win32') ? '\' : '/')
+  \ . ' -w-macro-params %s -o ' . (has('win32') ? 'NUL' : '/dev/null')
 
 Execute(The options should be used in command):
   let b:ale_nasm_nasm_options = '-w+orphan-labels'

test/command_callback/test_pydocstyle_command_callback.vader

@@ -7,34 +7,34 @@ After:
 
 Execute(The pydocstyle command callback should return default string):
   AssertLinter 'pydocstyle',
-  \ ale#path#CdString(expand('#' . bufnr('') . ':p:h'))
-  \   . ale#Escape('pydocstyle') . '  ' . ale#Escape('test.py')
+  \ ale#path#BufferCdString(bufnr(''))
+  \   . ale#Escape('pydocstyle') . ' %s:t'
 
 Execute(The pydocstyle command callback should allow options):
   let g:ale_python_pydocstyle_options = '--verbose'
 
   AssertLinter 'pydocstyle',
-  \ ale#path#CdString(expand('#' . bufnr('') . ':p:h'))
-  \   . ale#Escape('pydocstyle') . ' --verbose ' . ale#Escape('test.py')
+  \ ale#path#BufferCdString(bufnr(''))
+  \   . ale#Escape('pydocstyle') . ' --verbose %s:t'
 
 Execute(The pydocstyle executable should be configurable):
   let g:ale_python_pydocstyle_executable = '~/.local/bin/pydocstyle'
 
   AssertLinter '~/.local/bin/pydocstyle',
-  \ ale#path#CdString(expand('#' . bufnr('') . ':p:h'))
-  \   . ale#Escape('~/.local/bin/pydocstyle') . '  ' . ale#Escape('test.py')
+  \ ale#path#BufferCdString(bufnr(''))
+  \   . ale#Escape('~/.local/bin/pydocstyle') . ' %s:t'
 
 Execute(Setting executable to 'pipenv' appends 'run pydocstyle'):
   let g:ale_python_pydocstyle_executable = 'path/to/pipenv'
 
   AssertLinter 'path/to/pipenv',
-  \ ale#path#CdString(expand('#' . bufnr('') . ':p:h'))
-  \   . ale#Escape('path/to/pipenv') . ' run pydocstyle  ' . ale#Escape('test.py')
+  \ ale#path#BufferCdString(bufnr(''))
+  \   . ale#Escape('path/to/pipenv') . ' run pydocstyle %s:t'
 
 Execute(Pipenv is detected when python_pydocstyle_auto_pipenv is set):
   let g:ale_python_pydocstyle_auto_pipenv = 1
   call ale#test#SetFilename('../python_fixtures/pipenv/whatever.py')
 
   AssertLinter 'pipenv',
-  \ ale#path#CdString(expand('#' . bufnr('') . ':p:h'))
-  \   . ale#Escape('pipenv') . ' run pydocstyle  ' . ale#Escape('whatever.py')
+  \ ale#path#BufferCdString(bufnr(''))
+  \   . ale#Escape('pipenv') . ' run pydocstyle %s:t'