drop dead trait, dead test guards, and migrate async_mpi receiver to native P2300#7244
Conversation
…native P2300 Signed-off-by: guptapratykshh <[email protected]>
Up to standards ✅🟢 Issues
|
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Pull request overview
Removes leftover stdexec-test guards and obsolete completion signature detection code, and updates async_mpi’s transform_mpi_* sender/receiver types to use the member-based P2300 receiver/sender shape instead of tag_invoke for set_*/connect.
Changes:
- Deleted dead stdexec-guarded tests/blocks in execution_base unit tests and removed the now-unused unit test target.
- Removed the obsolete
detail::has_completion_signaturestrait and its remaining test usage. - Migrated async_mpi
transform_mpi_receiver/transform_mpi_senderto memberset_value/set_error/set_stoppedand memberconnect(keepingtag_invoke(get_completion_signatures_t, ...)).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| libs/core/execution_base/tests/unit/test_tag_invoke_only_completion_signatures.cpp | Removed a unit test file that was effectively disabled by stdexec configuration. |
| libs/core/execution_base/tests/unit/coroutine_utils.cpp | Removed dead stdexec-guarded assertions for the removed awaitable-as-sender path; added explanatory note. |
| libs/core/execution_base/tests/unit/completion_signatures.cpp | Removed assertion that depended on the deleted has_completion_signatures trait. |
| libs/core/execution_base/tests/unit/CMakeLists.txt | Removed the deleted test target from the unit test list. |
| libs/core/execution_base/include/hpx/execution_base/completion_signatures.hpp | Deleted the obsolete detail::has_completion_signatures trait. |
| libs/core/async_mpi/include/hpx/async_mpi/transform_mpi.hpp | Updated transform_mpi sender/receiver to member-based P2300 forms for set_* and connect. |
| auto&& result = | ||
| HPX_INVOKE(f, HPX_FORWARD(Ts, ts)..., &request); | ||
| set_value_request_callback_non_void(request, | ||
| HPX_MOVE(r.r), HPX_MOVE(result), | ||
| HPX_MOVE(r), HPX_MOVE(result), | ||
| HPX_FORWARD(Ts, ts)...); |
There was a problem hiding this comment.
pre-existing issue in the master
There was a problem hiding this comment.
@guptapratykshh Can you please fix this while you're touching this code?
Proposed Changes
Any background context you want to provide?
Checklist
Not all points below apply to all pull requests.