actions_base: add auto-registration to reflect_action by Priyanshi507 · Pull Request #7298 · TheHPXProject/hpx

Priyanshi507 · 2026-05-27T12:57:05Z

Summary

reflect_action now automatically registers its invocation counter
via a static register_action_invocation_count member — eliminating
the need for HPX_REGISTER_ACTION for reflection-based plain actions.

Design

Follows HPX's existing auto-registration pattern already used by
register_action<Action> in register_action.hpp:

template <std::meta::info F>
struct reflect_action : basic_action<...> {
    // Auto-registers during static initialization
    static detail::register_action_invocation_count<reflect_action<F>>
        invocation_count_registrar_;
};

What's still needed

The explicit transfer_action<reflect_action<F>> instantiation
(for shared library export) still requires HPX_REGISTER_ACTION
in non-reflection builds. For reflection builds, users can omit
HPX_REGISTER_ACTION entirely.

Depends on

PR actions_base: add reflection-based action definition (reflect_action) #7266 (merged) — reflect_action core
PR actions_base: integrate reflect_action with basic_action #7281 (merged) — basic_action integration

Checklist

I have added a new feature and have added tests to go along with it.

reflect_action now includes a static register_action_invocation_count member that automatically registers the action's invocation counter during static initialization — no HPX_REGISTER_ACTION call needed. This follows HPX's existing auto-registration pattern (already used by register_action<Action> in register_action.hpp) and eliminates boilerplate for reflection-based plain actions. The explicit transfer_action instantiation (for shared library export) still requires HPX_REGISTER_ACTION for non-reflection builds, but reflect_action users can omit it entirely. Signed-off-by: Priyanshi507 <hiiuiuiabi@gmail.com>

Signed-off-by: Priyanshi507 <hiiuiuiabi@gmail.com>

StellarBot · 2026-05-27T13:00:04Z

Can one of the admins verify this patch?

Signed-off-by: Priyanshi507 <hiiuiuiabi@gmail.com>

codacy-production · 2026-05-27T13:06:56Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

Signed-off-by: Priyanshi507 <hiiuiuiabi@gmail.com>

Add Derived template parameter following the same pattern as plain_action for future extensibility: template <std::meta::info F, typename Derived = void> struct reflect_action : basic_action<detail::plain_function, func_type, detail::action_type_t<reflect_action<F, Derived>, Derived>> This allows user-defined types to derive from reflect_action<F> to customize behavior, matching the extensibility of make_action_t. Signed-off-by: Priyanshi507 <hiiuiuiabi@gmail.com>

…strar_ Both the in-class declaration and out-of-class definition of invocation_count_registrar_ now consistently use reflect_action<F, Derived>. Signed-off-by: Priyanshi507 <hiiuiuiabi@gmail.com>

…trar_ Signed-off-by: Priyanshi507 <hiiuiuiabi@gmail.com>

hkaiser

Otherwise, LGTM, thanks!

Inside reflect_action's class body, 'reflect_action' refers to 'reflect_action<F, Derived>' via the injected class name, so we can simplify: - action_type_t<reflect_action<F, Derived>, Derived> -> action_type_t<reflect_action, Derived> - register_action_invocation_count<reflect_action<F, Derived>> -> register_action_invocation_count<reflect_action> Suggested by hkaiser. Signed-off-by: Priyanshi507 <hiiuiuiabi@gmail.com>

hkaiser

LGTM, thanks!

…t_action) Summary Extends reflect_action with reflect_component_action<F> — a C++26 reflection-based replacement for HPX_DEFINE_COMPONENT_ACTION. Before (3 manual steps): HPX_DEFINE_COMPONENT_ACTION(server, compute, compute_action) HPX_REGISTER_ACTION_DECLARATION(compute_action) HPX_REGISTER_ACTION(compute_action) After (single line): HPX_COMPONENT_ACTION(server, compute, compute_action); Design - reflect_component_action_base<F> extracts component_type via parent_of(F) and func_type via type_of(F) — two-step workaround following the same pattern as reflect_action_base<F> - reflect_component_action<F, Derived> inherits from basic_action<component_type, func_type, action_type_t<...>> - Auto-registration via static invocation_count_registrar_ member following the same pattern as reflect_action<F> - HPX_COMPONENT_ACTION(component, func, name) macro as cross-compiler fallback (GCC trunk + Clang P2996) Depends on - PR TheHPXProject#7298 (merged) — reflect_action with Derived parameter Signed-off-by: Priyanshi507 <hiiuiuiabi@gmail.com>

Priyanshi507 requested a review from hkaiser as a code owner May 27, 2026 12:57

actions_base: add test for reflect_action auto-registration member

47ddeda

Signed-off-by: Priyanshi507 <hiiuiuiabi@gmail.com>

actions_base: add missing type_traits include in reflect_action_test

4109be3

Signed-off-by: Priyanshi507 <hiiuiuiabi@gmail.com>

Priyanshi507 added 2 commits May 27, 2026 15:18

actions_base: fix non-ASCII em dash in reflect_action.hpp comment

1c89097

Signed-off-by: Priyanshi507 <hiiuiuiabi@gmail.com>

actions_base: fix remaining non-ASCII em dash in comment

b3c8b77

Signed-off-by: Priyanshi507 <hiiuiuiabi@gmail.com>

hkaiser added type: enhancement category: actions type: compatibility issue labels May 27, 2026

hkaiser reviewed May 27, 2026

View reviewed changes

Comment thread libs/full/actions_base/include/hpx/actions_base/reflect_action.hpp Outdated

Priyanshi507 added 2 commits May 27, 2026 18:05

actions_base: fix Derived type inconsistency in invocation_count_regi…

624d94f

…strar_ Both the in-class declaration and out-of-class definition of invocation_count_registrar_ now consistently use reflect_action<F, Derived>. Signed-off-by: Priyanshi507 <hiiuiuiabi@gmail.com>

Priyanshi507 mentioned this pull request May 27, 2026

Fixing various smaller issues in build system #7299

Merged

actions_base: fix malformed template syntax in invocation_count_regis…

a9cb2d2

…trar_ Signed-off-by: Priyanshi507 <hiiuiuiabi@gmail.com>

hkaiser previously approved these changes May 27, 2026

View reviewed changes

Comment thread libs/full/actions_base/include/hpx/actions_base/reflect_action.hpp Outdated

Comment thread libs/full/actions_base/include/hpx/actions_base/reflect_action.hpp Outdated

hkaiser added this to the 2.0.0 milestone May 27, 2026

Priyanshi507 dismissed hkaiser’s stale review via be7ecae May 28, 2026 09:20

hkaiser approved these changes May 28, 2026

View reviewed changes

hkaiser merged commit 275a67d into TheHPXProject:master May 28, 2026
73 checks passed

Priyanshi507 mentioned this pull request Jun 2, 2026

actions_base: add reflection-based component action (reflect_component_action) #7311

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

actions_base: add auto-registration to reflect_action#7298

actions_base: add auto-registration to reflect_action#7298
hkaiser merged 9 commits into
TheHPXProject:masterfrom
Priyanshi507:reflect-action-auto-register

Priyanshi507 commented May 27, 2026

Uh oh!

StellarBot commented May 27, 2026

Uh oh!

codacy-production Bot commented May 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

hkaiser left a comment

Uh oh!

Uh oh!

Uh oh!

hkaiser left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Priyanshi507 commented May 27, 2026

Summary

Design

What's still needed

Depends on

Checklist

Uh oh!

StellarBot commented May 27, 2026

Uh oh!

codacy-production Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

Uh oh!

hkaiser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hkaiser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codacy-production Bot commented May 27, 2026 •

edited

Loading