-
-
Notifications
You must be signed in to change notification settings - Fork 187
feat(deps): add support for Python 3.13 and later #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This should be reverted once: TheKevJames/coveralls-python#542 is merged.
@TheKevJames could you kindly check this PR? |
This should be reverted once: TheKevJames/coveralls-python#542 is merged.
This should be reverted once: TheKevJames/coveralls-python#542 is merged.
This should be reverted once: TheKevJames/coveralls-python#542 is merged.
This should be reverted once: TheKevJames/coveralls-python#542 is merged.
Any update? |
pyproject.toml
Outdated
@@ -31,7 +31,7 @@ coveralls = "coveralls.cli:main" | |||
python-coveralls = "coveralls.cli:main" | |||
|
|||
[tool.poetry.dependencies] | |||
python = ">=3.8,<3.13" | |||
python = ">=3.8,<3.14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend removing the upper limit, it will prevent this problem next year (and beyond) and also prevents us testing our projects on 3.14 now (it's already in alpha):
python = ">=3.8,<3.14" | |
python = ">=3.8" |
See https://iscinumpy.dev/post/bound-version-constraints/ for the long version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
7fb2b53
to
0ff8f20
Compare
Hi, |
@@ -31,7 +31,7 @@ coveralls = "coveralls.cli:main" | |||
python-coveralls = "coveralls.cli:main" | |||
|
|||
[tool.poetry.dependencies] | |||
python = ">=3.8,<3.13" | |||
python = ">=3.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python = ">=3.8" | |
python = "^3.8" |
This might be a better fit because it would allow any Python version 3.x that is newer than 3.8, but would intentionally break at any higher major version, such as Python 4.x, even if this is not yet foreseeable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good idea. Changed as suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI didn't like this so I had to change this back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this change instead?
python = ">=3.8" | |
python = ">=3.8,<4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python 4 is unlikely:
- https://www.techrepublic.com/article/programming-languages-why-python-4-0-will-probably-never-arrive-according-to-its-creator/
- https://web.archive.org/web/20220906155615/https://twitter.com/gvanrossum/status/1306082472443084801
- https://discuss.python.org/t/python-3-13-alpha-1-contains-breaking-changes-whats-the-plan/37490/11
Even if there is, it's too late - there are already coveralls releases without the upper pin, and pip will end up installing those really old versions.
I recommend ">=3.8"
.
### What kind of change does this PR introduce? * Limits the Python version to 3.12 as not all CI dependencies are available for Python 3.13 ### Does this PR introduce a breaking change? No. ### Other information: TheKevJames/coveralls-python#542
Any update? |
@terop do you know why the circleci jobs are all failing? I'm not able to see the test logs given that it requires a login. :/ |
7bea4ff
to
fe1eed2
Compare
fe1eed2
to
73247a8
Compare
Kind of, the error can be seen below. I am not familiar with the CI setup of this project so I cannot say how this should be fixed.
|
@TheKevJames Would you please take a look at this? This PR is effectively blocking downstream packages from updating, see e.g. linked PRs above. |
Python 3.13 has been released last week so add support for it so that early adopters can use it.