Skip to content

feat(deps): add support for Python 3.13 and later #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

terop
Copy link

@terop terop commented Oct 18, 2024

Python 3.13 has been released last week so add support for it so that early adopters can use it.

@terop terop requested a review from TheKevJames as a code owner October 18, 2024 17:09
felddy added a commit to felddy/foundryvtt-docker that referenced this pull request Oct 22, 2024
@terop
Copy link
Author

terop commented Nov 5, 2024

@TheKevJames could you kindly check this PR?

felddy added a commit to felddy/foundryvtt-docker that referenced this pull request Nov 8, 2024
felddy added a commit to felddy/foundryvtt-docker that referenced this pull request Nov 8, 2024
felddy added a commit to felddy/reusable-workflows that referenced this pull request Nov 8, 2024
felddy added a commit to felddy/reusable-workflows that referenced this pull request Nov 8, 2024
@meherett
Copy link

Any update?

pyproject.toml Outdated
@@ -31,7 +31,7 @@ coveralls = "coveralls.cli:main"
python-coveralls = "coveralls.cli:main"

[tool.poetry.dependencies]
python = ">=3.8,<3.13"
python = ">=3.8,<3.14"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend removing the upper limit, it will prevent this problem next year (and beyond) and also prevents us testing our projects on 3.14 now (it's already in alpha):

Suggested change
python = ">=3.8,<3.14"
python = ">=3.8"

See https://iscinumpy.dev/post/bound-version-constraints/ for the long version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@terop terop force-pushed the python_313_support branch from 7fb2b53 to 0ff8f20 Compare December 16, 2024 08:52
@terop terop changed the title feat(deps): add Python 3.13 support feat(deps): add support for Python 3.13 and later Dec 16, 2024
@EvanBldy
Copy link

EvanBldy commented Jan 9, 2025

Hi,
any update on this ? when do you plan to do a release with this ?

@@ -31,7 +31,7 @@ coveralls = "coveralls.cli:main"
python-coveralls = "coveralls.cli:main"

[tool.poetry.dependencies]
python = ">=3.8,<3.13"
python = ">=3.8"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python = ">=3.8"
python = "^3.8"

This might be a better fit because it would allow any Python version 3.x that is newer than 3.8, but would intentionally break at any higher major version, such as Python 4.x, even if this is not yet foreseeable.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good idea. Changed as suggested.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI didn't like this so I had to change this back.

Copy link

@nielstron nielstron Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this change instead?

Suggested change
python = ">=3.8"
python = ">=3.8,<4.0"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zeitsperre added a commit to CSHS-CWRA/RavenPy that referenced this pull request Jan 27, 2025
### What kind of change does this PR introduce?

* Limits the Python version to 3.12 as not all CI dependencies are
available for Python 3.13

### Does this PR introduce a breaking change?

No.

### Other information:

TheKevJames/coveralls-python#542
@keyfayaz
Copy link

Any update?

@whimboo
Copy link

whimboo commented Apr 16, 2025

@terop do you know why the circleci jobs are all failing? I'm not able to see the test logs given that it requires a login. :/

@terop terop force-pushed the python_313_support branch 2 times, most recently from 7bea4ff to fe1eed2 Compare April 16, 2025 16:20
@terop terop force-pushed the python_313_support branch from fe1eed2 to 73247a8 Compare April 16, 2025 16:33
@terop
Copy link
Author

terop commented Apr 16, 2025

@terop do you know why the circleci jobs are all failing? I'm not able to see the test logs given that it requires a login. :/

Kind of, the error can be seen below. I am not familiar with the CI setup of this project so I cannot say how this should be fixed.

upload: commands[0]> coveralls --verbose
Missing .coveralls.yml file. Using only env variables.
Error running coveralls: Not on TravisCI. You have to provide either repo_token in .coveralls.yml or set the COVERALLS_REPO_TOKEN env var.
Traceback (most recent call last):
  File "/root/project/coveralls/cli.py", line 65, in main
    coverallz = Coveralls(
                ^^^^^^^^^^
  File "/root/project/coveralls/api.py", line 47, in __init__
    self.ensure_token()
  File "/root/project/coveralls/api.py", line 60, in ensure_token
    raise CoverallsException(
coveralls.exception.CoverallsException: Not on TravisCI. You have to provide either repo_token in .coveralls.yml or set the COVERALLS_REPO_TOKEN env var.
upload: exit 1 (0.24 seconds) /root/project> coveralls --verbose pid=2158
.pkg: _exit> python /usr/local/lib/python3.11/site-packages/pyproject_api/_backend.py True poetry.core.masonry.api
  upload: FAIL code 1 (4.84=setup[4.59]+cmd[0.24] seconds)
  evaluation failed :( (5.11 seconds)

Exited with code exit status 1

@bartvanandel
Copy link

@TheKevJames Would you please take a look at this? This PR is effectively blocking downstream packages from updating, see e.g. linked PRs above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants