fix: fix CI pipeline — Docker push, Trivy scanner, k6, remove OWASP Maven#2166
Open
Wachhund wants to merge 1 commit into
Open
fix: fix CI pipeline — Docker push, Trivy scanner, k6, remove OWASP Maven#2166Wachhund wants to merge 1 commit into
Wachhund wants to merge 1 commit into
Conversation
…, remove OWASP Maven - docker.yml: add GHCR login and push steps so images are actually published - docker.yml: fix Trivy scan-ref to use image-ref with actual built image names - load-tests.yml: add pnpm/action-setup and k6 apt installation - ci.yml: remove owasp-dependency-check job (Maven against Node.js project)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker/login-action@v3) anddocker pushsteps so built images are actually published to the registry. Previously, images were tagged forghcr.iobut never pushed — every build produced zero persistent artifactsscan-type: 'image'requiresimage-ref(image name), notscan-ref: '.'(filesystem path). Split into separate API and Web image scanspnpm/action-setup@v4(pnpm was missing, causingcache: pnpmto fail) and install k6 via apt (k6 is a Go binary, not available via npx)POSTGRES_PASSWORDenv var todocker compose upstepowasp-dependency-checkjob that runs Maven (mvn org.owasp:dependency-check-maven:6.8.1:check) against a project with nopom.xml— always fails. Node.js vulnerability scanning is already covered bypnpm auditin thedependency-auditjobCloses #2005
Test plan