fix: incident schema validation prevents API startup#2172
Open
Wachhund wants to merge 1 commit into
Open
Conversation
…atibility Fastify interprets route schemas as JSON Schema objects. The incident schema used z.string().or(z.date()) and z.union([z.literal()]) which produce invalid JSON Schema (data/required must be array), preventing the API from starting. Replaced with simple z.string() and z.number() since dates arrive as ISO strings over HTTP.
Author
|
Relates to #1747 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes API startup crash:
Failed building the validation schema for GET: /api/v1/game/sessions/:sessionId/incidents, due to error schema is invalid: data/required must be arrayThe incident route schemas used Zod types that produce invalid JSON Schema when Fastify processes them:
z.string().or(z.date())→ replaced withz.string()(dates arrive as ISO strings over HTTP)z.union([z.literal(1), z.literal(2), z.literal(3), z.literal(4)])→ replaced withz.number().int().min(1).max(4)One file changed, 5 lines.
Test plan