This repository was archived by the owner on Oct 7, 2022. It is now read-only.
Fix tests on windows and add UB warning for YAML DeSer #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were due to open temp file handles, which prohibited the used tempfile to be replaced by our atomic save mechanism.
See issue TheNeikos#87 for details.
This was referenced Jan 21, 2021
niluxv
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tempfile leak in integration test, fix tests failing on windows due to open tempfile handles locking those files and document the YAML DeSer UB in the README and the API documentation.