Skip to content

Always set isDirectConnect variable when announcing LAN game #1802

New issue
New issue
Open
Bug
#1836
Open
Always set isDirectConnect variable when announcing LAN game#1802
Bug
#1836
Labels
BugSomething is not working right, typically is user facingMinorSeverity: Minor < Major < Critical < BlockerNetworkAnything related to network, serversStabilityConcerns stability of the runtime
@Caball009

Description

@Caball009
Caball009
opened on Nov 5, 2025

When a game host announces their game to the lobby, the message is supposed to set GameInfo.isDirectConnect like so:

GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameNetwork/LANAPI.cpp

Lines 717 to 718 in e2385c5

reply.GameInfo.inProgress = m_currentGame->isGameInProgress();
reply.GameInfo.isDirectConnect = m_currentGame->getIsDirectConnect();

GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameNetwork/LANAPIhandlers.cpp

Lines 197 to 198 in e2385c5

reply.GameInfo.inProgress = m_currentGame->isGameInProgress();
reply.GameInfo.isDirectConnect = m_currentGame->getIsDirectConnect();

The same should be done below, otherwise the game may read uninitialized memory when parsing this message:

GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameNetwork/LANAPIhandlers.cpp

Lines 67 to 68 in e2385c5

reply.GameInfo.inProgress = m_currentGame->isGameInProgress();

Additionally, m_isDirectConnect should probably be initialized in the constructor here:

GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameNetwork/LANGameInfo.cpp

Lines 89 to 100 in e2385c5

LANGameInfo::LANGameInfo()
{
//Added By Sadullah Nader
//Initializtions missing and needed
m_lastHeard = 0;
m_next = NULL;
//
for (Int i = 0; i< MAX_SLOTS; ++i)
setSlotPointer(i, &m_LANSlot[i]);
setLocalIP(TheLAN->GetLocalIP());
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething is not working right, typically is user facingMinorSeverity: Minor < Major < Critical < BlockerNetworkAnything related to network, serversStabilityConcerns stability of the runtime

    Type

    Bug

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions