forked from electronicarts/CnC_Generals_Zero_Hour
-
Notifications
You must be signed in to change notification settings - Fork 124
Labels
MajorSeverity: Minor < Major < Critical < BlockerSeverity: Minor < Major < Critical < BlockerRefactorEdits the code with insignificant behavior changes, is never user facingEdits the code with insignificant behavior changes, is never user facing
Description
The code uses DirectX functions reinterpret_cast's to convert matrices from row major to column major and vice versa. The DirectX functions need to be replaced, the reinterpret_cast's removed.
Reference change:
TheAssemblyArmada/Thyme@2114738
// When converting Matrix4 to D3DMATRIX or vice versa always use conversion function below.
// Reason being, D3DMATRIX is row major matrix, and Matrix4 is column major matrix.
// Thus copying from one to another will always require a transpose (or invert).
Metadata
Metadata
Assignees
Labels
MajorSeverity: Minor < Major < Critical < BlockerSeverity: Minor < Major < Critical < BlockerRefactorEdits the code with insignificant behavior changes, is never user facingEdits the code with insignificant behavior changes, is never user facing