More Furniture Changes #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix existing custom interactions not running due to incorrect file names - Rework custom interactions to target the item display instead of the interaction, allowing for interactions to more easily affect the item display - Add custom interactions to candles and the fancy lamp shade. Candles need to be lit and can be extinguished. Fancy lamp shade places lit but can be toggled on and off with an interaction.
- trying to mimic a lamp pull chain click sound
…iet and mostly just bubble sounds
- I wanted interact/detect to be expandable if needed
- Added a check to place functions to check for existing furniture and fail if so, and replace block - Added check to main for non furniture blocks in furniture, causing them to break - All furniture now store the block_id on the item display's custom data, which must be updated when block state is changed through custom interactions
- Imported: Iron Desk Lamp, Iron Spotlight, Iron Foldable Chair (dyeable), Small Medium and Large Stone Lanterns - Add a custom placement system allowing functions to be run at new furniture location after successful placement, allowing custom placement modifications - Spotlight is a little silly. I adjusted the transparency to get the beam visible, which will probably need to be changed when we add emissive textures back - Spotlight is placed facing the player, unless sneaking, when it is placed facing away from the player - Spotlights can also be toggled on and off on interact
- When dyeing the chair #529cc1, it appears. This is the closest you can get to #4aa0c7, GM4 blue
…anized by type instead of theme
Author
|
Marking this as a draft for now. The intention being that I'm still working on it, but if you want to merge it at any point, I can always make another PR |
This was not an issue, but a personal gripe. I wanted wood to be the first thing you see.
- for candles - for paintbrushes, can right click with paintbrush in offhand - for waterlogging, can use buckets in either hand. Also solved a bug where the furniture waterlogging replaced stacked buckets with 1 water bucket - moved the $check_id score set to be in interact/process, allowing some processes to be run as the player - I might investigate moving the candle lighting item data out of interact/detect, but for now it lives there :) ...
- I forgor
- interaction should check gametime and UUID to be extra sure it is the correct interaction entity
- where it's actually used
* New module: Reeling Rods (Gamemode4Dev#1104) * Shrink Blossoming Pots pack.png * Shrink Reeling Rods pack.png (Gamemode4Dev#1153) * Update raw wood set file. Add cherry models and textures for bench, stool and chair. Remove version from spruce model files. * Add Reeling Rods Smithed ID (Gamemode4Dev#1156)
Author
|
Closing this. Now tracked on Gamemode4Dev#1158 as a new main repo PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a few issues and some bigger custom interaction changes.
Added custom interactions for candles and the fancy lamp shade.
and.. Uh a lot more