doc: Add attributes to uplink message data format #1397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlasebian
force-pushed
the
device-attributes
branch
from
c3c547d to
1b925d8
Compare
KrishnaIyer
requested changes
Jan 29, 2025
Contributor
KrishnaIyer
left a comment
KrishnaIyer
left a comment
There was a problem hiding this comment.
Please add the new-in-version tag and set that to v3.34.0.
vlasebian
force-pushed
the
device-attributes
branch
from
1b925d8 to
3e90b0d
Compare
Contributor
Author
|
I've added the tag near the new fields, but the formatting isn't looking good. The tag formatting conflicts with the code block: 
Eventually I simply added a note at the beginning of the page prefixed with the tag:
|
KrishnaIyer
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References #7451 in thethingsnetwork/lorawan-stack.
Screenshots
Changes
Notes for Reviewers
None.
Checklist
make server, posted screenshots, verified external links. Test withHUGO_PARAMS_SEARCH_ENABLED=trueif style changes will affect the search bar.new-in-versionshortcode, according to the guidelines in CONTRIBUTING.