Skip to content

Conversation

@happyRip
Copy link
Member

@happyRip happyRip commented May 26, 2025

Summary

References https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1293

Screenshots

Nothing changed visually

Changes

  • Add missing id to the Download button

Notes for Reviewers

During UI updates the ID of the Download button disappeared and the script stopped working.

I've tested the functionality locally and it's working after the fix.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Run Locally: Verified that the docs build using make server, posted screenshots, verified external links. Test with HUGO_PARAMS_SEARCH_ENABLED=true if style changes will affect the search bar.
  • New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
  • Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
  • Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

@happyRip happyRip added this to the May 2025 milestone May 26, 2025
@happyRip happyRip self-assigned this May 26, 2025
@happyRip happyRip requested a review from KrishnaIyer May 26, 2025 06:32
@KrishnaIyer KrishnaIyer merged commit 3eb78c1 into master May 26, 2025
1 check passed
@KrishnaIyer KrishnaIyer deleted the fix/cli-downloader branch May 26, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants