Skip to content

Refactor and Features : V1.1.2 #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

wtc-peg
Copy link
Contributor

@wtc-peg wtc-peg commented Mar 11, 2025

Summary

Feature & Refactor: Feat: Optional batch and EP Equiv parameters for API. Global build of v1.1.2 before new deployment for Watteco, Actility, TTN, and NPM repositories

...

Changes

  • Feature: Add decodeUplink API Optional parameters allowing decoding customization by user when Batch config or Endpoint equivalence changed
  • Refactor namming, json device files and version management for actility deployment
  • Refactor Array in examples YAML files during TTN deployment

Checklist for Reviewers

  • Title and description should be descriptive (Not just a serial number for example).
  • profileIDs should not be vendorID and should be a unique value for every profile.
  • All devices should be listed in the vendor's index.yaml file.
  • Firmware versions can not be changed.
  • At least 1 image per device and should be transparent.

Notes for Reviewers

...

Release Notes

  • ...

wtc-peg and others added 10 commits February 7, 2025 17:33
…lutions (v1.1.1) for Watteco, Actility, TTN, and NPM repositories

Key objectives for this build:
- Added new TTN Watteco vendor (former nke_watteco retained for compatibility)
- TS013 compliance: ES5 output, decoder size < 64KB, output format, API conformance
- Added new sensors, removed/renamed others
- Enhanced utilities for easier build and repository synchronization (watteco repositorsy)
- Passed Watteco and TTN test procedures
- Addressed compatibility with platforms requiring strict (older) ES5 support
… API. Global build of v1.1.2 before new deployment for Watteco, Actility, TTN, and NPM repositories

Key objectives for this build:
- Feature: Add decodeUplink API Optional parameters allowing decoding customization by user when Batch config or Endpoint equivalence changed
- Refactor namming, json device files and version management for actility deployment
- Refactor Array in examples YAML files during TTN deployment
@wtc-peg wtc-peg requested a review from Jaime-Trinidad as a code owner March 11, 2025 13:39
wtc-peg added 2 commits March 31, 2025 13:31
- Ensure two-digit hexadecimal representation for Modbus data
- Correct example payloads
@Jaime-Trinidad
Copy link
Contributor

Hi @wtc-peg there is an inconsistency in the decoder output related to the DebP field. The value of this field differs depending on the environment where the decoder is executed (e.g., local machine vs. GitHub CI), which causes the validation to fail.

The issue appears to come from the handling of timestamps or date conversion in the normalisation_batch function, located in vendor/watteco/ticso.js

Please review the DebP field and ensure that the date output is consistent across all environments, regardless of the local timezone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants