Add HCA 3.0 decoding support#138
Draft
segfault-bilibili wants to merge 2 commits into
Draft
Conversation
segfault-bilibili
force-pushed
the
hca3.0
branch
from
bc35476 to
1631ff9
Compare
| } | ||
| int curvePosition = noiseLevel - 5 * scaleFactor / 2 + 2; | ||
| //https://github.com/vgmstream/vgmstream/blob/4eecdada9a03a73af0c7c17f5cd6e08518fd7e3f/src/coding/hca_decoder_clhca.c#L1450 | ||
| if (version >= 0x0300 && curvePosition >= 67) return 0; //FIXME |
Author
There was a problem hiding this comment.
It seems that version >= 0x3000 cannot be removed, otherwise HCA 2.0 decoding would break.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported HCA3.0 decoding support from @bnnm's vgmstream.
Roughly tested to work, however I can see differences in frequency spectrum, especially > 11k bands.