epa::Face::normal Degenerate variant.#4
Closed
ThierryBerger wants to merge 16 commits intotodo_simplefrom
Closed
Conversation
…se of a degenerate face.
ThierryBerger
changed the title
ThierryBerger
commented
Sep 26, 2024
ThierryBerger
commented
Sep 27, 2024
ThierryBerger
commented
Sep 27, 2024
Owner
Author
|
See dimforge#284 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves a
TODOby using an explicit type instead of having a Unit Vector with length of 0 meaning the face was degenerate.