Upgrade for PureScript 0.12 #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@Thimoteus I'm not sure if I'm able to preserve instance for instance coercibleId :: Coercible a a where
coerce = identitybecause with this I think we are not able to provide any other instance. |
Owner
|
What happens if you put it last in the instance chain? Can you show that it'll never get picked? |
Author
|
This is not really the problem. The problem is that it seems to overlap with any external instance... |
Owner
|
Hmm, that's a good point... |
Author
|
I'm migrating instance coercibleMaybeOptional :: Coercible (Maybe a) (Optional a) whereTo be honest my focus is to migrate |
Owner
|
Yeah, I think those are old enough to have been written before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.