Merged
Conversation
- Fix grammar: "There is" -> "There are" - Improve clarity: "are usable" -> "can be used" - Fix typo: remove ",." at end of sentence - Replace informal "The big difference" with "The main difference" - Clarify pronoun references for better readability - Standardize "back-end" to "backend" - Improve sentence flow and remove awkward phrasing
Add introductory section explaining that golem has two independent mechanisms for managing production vs development mode: - R options approach (options(golem.app.prod)) for golem utilities - Config file approach (golem-config.yml) for app-specific settings Add comprehensive recap section at end that: - Explains the R options mechanism and which functions use it - Clarifies that the two mechanisms are NOT automatically synchronized - Documents the different purposes and scopes of each approach - Provides best practices for when to use each mechanism - Shows example of syncing them if needed This addresses confusion raised in issue ThinkR-open#1220 where users expected config file changes to affect golem's dev/prod utilities.
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1220
@ColinFay I am not sure about the best practices writing part .. Maybe there is a way for a cleaner phrasing, but I think one should add a bit more context for that vignette because #1220 , #854 and #851 are more or less aiming at a clarification.