Skip to content

fix: workflow#92

Merged
ro80t merged 7 commits into
mainfrom
fix-wf
Jun 27, 2026
Merged

fix: workflow#92
ro80t merged 7 commits into
mainfrom
fix-wf

Conversation

@ro80t

@ro80t ro80t commented Jun 27, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Improved preview deployment reliability by ensuring each pull request uses a single, up-to-date run.
    • Cancelled outdated in-progress checks when new updates are pushed, reducing duplicate build activity.
    • Aligned preview-trigger behavior so opened, updated, reopened, and closed pull requests are handled consistently.

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@ro80t, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 48 minutes and 54 seconds. Learn how PR review limits work.

To continue reviewing without waiting, enable usage-based billing in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 923e5f6f-c1b9-44bb-85fd-0ea3a307e9ac

📥 Commits

Reviewing files that changed from the base of the PR and between 5cc42ee and eab1f02.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • .github/workflows/preview.yml
📝 Walkthrough

Walkthrough

The CI workflow now cancels earlier in-progress runs for the same pull request. The preview workflow updates its trigger event types, concurrency group, build job name, and downstream dependency.

Changes

Workflow run coordination

Layer / File(s) Summary
CI concurrency
.github/workflows/ci.yml
Adds a PR-scoped concurrency group and cancels in-progress CI runs for the same pull request.
Preview workflow wiring
.github/workflows/preview.yml
Updates the preview workflow name, trigger event list, concurrency group, Storybook build job name, and the preview job dependency.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • ThunLights/distopia#91: Adjusts GitHub Actions workflow trigger/event handling and preview deployment behavior in the same area of CI/preview orchestration.

Poem

I hop through workflows, neat and spry,
With PR-scoped runs that won’t multiply.
Storybook builds before preview gleams,
Then rabbit-soft CI follows new-commit streams. 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is generic and does not describe the specific workflow changes in CI and preview jobs. Rename it to mention the workflow update, e.g. "Add concurrency to CI and preview workflows".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-wf

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

github-actions Bot pushed a commit that referenced this pull request Jun 27, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yml:
- Around line 11-13: The concurrency group in the workflow is only using
github.event.pull_request.number, which is empty for push runs and causes
unrelated executions to share the same group. Update the concurrency
configuration to include a fallback for non-PR events, using the existing
concurrency block and the workflow context values such as
github.event.pull_request.number, github.run_id, or github.ref so each run gets
a distinct group when pull request number is unavailable.

In @.github/workflows/preview.yml:
- Around line 34-35: The build-storybook job is inheriting broader GITHUB_TOKEN
permissions than it needs; update the preview workflow so this job uses explicit
read-only permissions, or move the default to read-only and grant write access
only to preview and cleanup. Make the change in the build-storybook job
definition in the workflow so its token scope is limited to
checkout/upload-artifact only.
- Around line 3-7: The `cleanup` job in `preview.yml` is still triggered by both
`pull_request` and `pull_request_target` on `closed`, which causes a fork PR
cleanup run to hit `git push origin gh-pages` with a read-only token. Update the
job-level `if` for `cleanup` to use the same fork-aware event split as the
existing preview gating so only one of the two events can run it for a given PR.
Use the `cleanup` job and the existing `pull_request`/`pull_request_target`
condition logic as the reference points when making the change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0e85e90c-150b-41a2-a92e-988e3b739b20

📥 Commits

Reviewing files that changed from the base of the PR and between d65e41d and 5cc42ee.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • .github/workflows/preview.yml

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/preview.yml
Comment thread .github/workflows/preview.yml
@github-actions

Copy link
Copy Markdown
Contributor

github-actions Bot pushed a commit that referenced this pull request Jun 27, 2026
@ro80t ro80t merged commit 735b4e9 into main Jun 27, 2026
26 checks passed
@ro80t ro80t deleted the fix-wf branch June 27, 2026 00:36
github-actions Bot pushed a commit that referenced this pull request Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant