Pin the tensorflow version lower than 2.16#215
Merged
Conversation
ihnorton
approved these changes
Aug 26, 2024
Member
ihnorton
left a comment
There was a problem hiding this comment.
Please add a comment regarding the reason for the TF pin
Collaborator
Author
Sure added it in the PR's description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Reason:
Tensorflow >=2.16 comes with a default dependency of Keras backend >= 3.0. The latter introduces many changes in its package module, deprecates many modules, changes module paths and generally after some efforts supporting it in an open PR here #214 we were not able to support it with minimal changes in our package. It will require a restructure of our package and a holistic approach which given the current capacity we ll need to revisit it in the near future.