Revert "Updated spdlog to version 1.15.3" - #824
Merged
Conversation
This reverts commit e4b00ac.
jp-dark
approved these changes
Jul 21, 2025
jdblischak
approved these changes
Jul 21, 2025
Collaborator
|
I manually triggered a nightly build from this PR branch: https://github.com/TileDB-Inc/TileDB-VCF/actions/runs/16422969387 |
This was referenced Jul 21, 2025
alancleary
added a commit
that referenced
this pull request
Jul 24, 2025
* Bump nightly build release branch to 2.28 (#819) * fix img and academy links (#815) Use TileDB Academy links for docs * remove ENTRYPOINT for Nextflow compatibility (#816) * remove ENTRYPOINT for Nextflow compatibility * add tiledbvcf to test_cmd since no entrypoint * Updated spdlog to version 1.15.3 (#821) This required adding an include of fmt/ranges.h because of a bug in libfmt 11, which spdlog depends on. * Revert "Updated spdlog to version 1.15.3 (#821)" (#824) This reverts commit e4b00ac. * Updated HTSlib to version 1.22.1 (#822) * Updated HTSlib to version 1.22.1 This includes changing the CMake External Project URL hash for HTSlib to use a SHA256 checksum because GitHub now auto-generates SHA256 checksums for HTSlib release artifacts. * Removed unused HTSlib CMake patch * Updated Azure CI config to install curl prior to bcftools bcftools 1.22 contains a bug fix that causes the build in this configuration to fail if curl is not present. * Update to TileDB Embedded 2.28.1 --------- Co-authored-by: John Blischak <jdblischak@gmail.com> Co-authored-by: Jeremy Leipzig <jeremy.leipzig@tiledb.com>
alancleary
added a commit
that referenced
this pull request
Jul 24, 2025
* Bump nightly build release branch to 2.28 (#819) * fix img and academy links (#815) Use TileDB Academy links for docs * remove ENTRYPOINT for Nextflow compatibility (#816) * remove ENTRYPOINT for Nextflow compatibility * add tiledbvcf to test_cmd since no entrypoint * Updated spdlog to version 1.15.3 (#821) This required adding an include of fmt/ranges.h because of a bug in libfmt 11, which spdlog depends on. * Revert "Updated spdlog to version 1.15.3 (#821)" (#824) This reverts commit e4b00ac. * Updated HTSlib to version 1.22.1 (#822) * Updated HTSlib to version 1.22.1 This includes changing the CMake External Project URL hash for HTSlib to use a SHA256 checksum because GitHub now auto-generates SHA256 checksums for HTSlib release artifacts. * Removed unused HTSlib CMake patch * Updated Azure CI config to install curl prior to bcftools bcftools 1.22 contains a bug fix that causes the build in this configuration to fail if curl is not present. * Update to TileDB Embedded 2.28.1 --------- Co-authored-by: John Blischak <jdblischak@gmail.com> Co-authored-by: Jeremy Leipzig <jeremy.leipzig@tiledb.com>
alancleary
added a commit
that referenced
this pull request
Aug 26, 2025
* Bump nightly build release branch to 2.28 (#819) * fix img and academy links (#815) Use TileDB Academy links for docs * remove ENTRYPOINT for Nextflow compatibility (#816) * remove ENTRYPOINT for Nextflow compatibility * add tiledbvcf to test_cmd since no entrypoint * Updated spdlog to version 1.15.3 (#821) This required adding an include of fmt/ranges.h because of a bug in libfmt 11, which spdlog depends on. * Revert "Updated spdlog to version 1.15.3 (#821)" (#824) This reverts commit e4b00ac. * Updated HTSlib to version 1.22.1 (#822) * Updated HTSlib to version 1.22.1 This includes changing the CMake External Project URL hash for HTSlib to use a SHA256 checksum because GitHub now auto-generates SHA256 checksums for HTSlib release artifacts. * Removed unused HTSlib CMake patch * Updated Azure CI config to install curl prior to bcftools bcftools 1.22 contains a bug fix that causes the build in this configuration to fail if curl is not present. * Update TileDB Embedded to 2.28.1 (#826) (#827) * Bump nightly build release branch to 2.28 (#819) * fix img and academy links (#815) Use TileDB Academy links for docs * remove ENTRYPOINT for Nextflow compatibility (#816) * remove ENTRYPOINT for Nextflow compatibility * add tiledbvcf to test_cmd since no entrypoint * Updated spdlog to version 1.15.3 (#821) This required adding an include of fmt/ranges.h because of a bug in libfmt 11, which spdlog depends on. * Revert "Updated spdlog to version 1.15.3 (#821)" (#824) This reverts commit e4b00ac. * Updated HTSlib to version 1.22.1 (#822) * Updated HTSlib to version 1.22.1 This includes changing the CMake External Project URL hash for HTSlib to use a SHA256 checksum because GitHub now auto-generates SHA256 checksums for HTSlib release artifacts. * Removed unused HTSlib CMake patch * Updated Azure CI config to install curl prior to bcftools bcftools 1.22 contains a bug fix that causes the build in this configuration to fail if curl is not present. * Update to TileDB Embedded 2.28.1 --------- Co-authored-by: John Blischak <jdblischak@gmail.com> Co-authored-by: Jeremy Leipzig <jeremy.leipzig@tiledb.com> * Improve run-time performance of delete exporter (#833) * Added optional field filters to recover_record(...) method in Exporter class This allows what (materialized) info and format fields are added to the BCF record to be limited to a specific set. * Updated export_record(...) method in DeleteExporter class to only export genotype fields This is to improve run-time performance. * Update the Buffer class data() method to compute string view directly from offsets (#834) Co-authored-by: Julia Dark <julia@tiledb.com> * Deletion memory usage (#835) * Sample stats are now updated for one sample at a time during deletion Previously there was a bug where the stats for every sample being deleted were processed repeatedly as each sample was deleted. * Export parameters can now be passed to the dataset class's delete method This allows the reader used for this operation to be configured from outside the method, e.g. via the CLI. The previous method signature is preserverd as a wrapper for the new signature. * The deletion memory budget can now be controlled via the CLI * Applied clang-format * Added CLI deletion tests * Added multi sample deletion unit test --------- Co-authored-by: John Blischak <jdblischak@gmail.com> Co-authored-by: Jeremy Leipzig <jeremy.leipzig@tiledb.com> Co-authored-by: Julia Dark <julia@tiledb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #82 because this change is causing the nightly build on Ubuntu 24.04 to fail. Will revisit when a release is not imminent.