Draft
Conversation
Add a registry system centered on `class Registry`. The system supports automatic first-pass registration at construction time. Add a job system, a set of base classes for jobs. The job system is generic, with a mixin class to add application-specific behavior. The mixin class for the library deals with `StorageManager` and `ContextResources`, etc. There's only one remaining `StorageManager` member variable; it's in the mixin class. The `storage_manager()` accessor functions are also in the same place. `class JobRoot` is now a base class of `class Context`, now split into `ContextBase` and `Context` so that the storage manager member variable is available for the `JobRoot` constructor. `class JobBranch` is now a base class of `class Query` and `class Consolidator`, among others. Rework all the constructors to take a single `JobParent` argument rather than separate arguments for resources, cancellation sources, and storage managers. `JobParent::make_cancellation_source` is now the sole source of `CancellationSource` objects. Add `Context::cancel_all_tasks()`, currently as a proxy for the same function in `StorageManager`. This allowed removal of the accessor `storage_manager()` in the context C API handle. Remove now-unused `tiledb_ctx_handle_t::make_cancellation_source()`.
…gcc`. clang-format
eric-hughes-tiledb
force-pushed
the
eh/activity-tracking
branch
from
b908ad9 to
3dc230b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a job system, a set of base classes for jobs. The job system is generic, with a mixin class to add application-specific behavior. The mixin class for the library deals with
StorageManagerandContextResources, etc. There's only one remainingStorageManagermember variable; it's in the mixin class. Thestorage_manager()accessor functions are also in the same place.Add a registry system centered on
class Registry. The system supports automatic first-pass registration at construction time. This registry is the basic for the tree structure in the job system.class JobRootis now a base class ofclass Context, now split intoContextBaseandContextso that the storage manager member variable is available for theJobRootconstructor.class JobBranchis now a base class ofclass Queryandclass Consolidator, among others. Rework all the constructors to take a singleJobParentargument rather than separate arguments for resources, cancellation sources, and storage managers.JobParent::make_cancellation_sourceis now the sole source ofCancellationSourceobjects. AddContext::cancel_all_tasks(), currently as a proxy for the same function inStorageManager. This allowed removal of the accessorstorage_manager()in the context C API handle. Remove now-unusedtiledb_ctx_handle_t::make_cancellation_source().TYPE: IMPROVEMENT
DESC: Job system for activity tracking