Optimize opening arrays — part 2 - #5662
Merged
Merged
Conversation
ypatia
approved these changes
Oct 13, 2025
| * @param create_raw CreateRawMarker dummy value. | ||
| * @param uri Rvalue reference to string. | ||
| */ | ||
| URI(const CreateRawMarker, std::string&& uri) |
Member
There was a problem hiding this comment.
Suggested change
| URI(const CreateRawMarker, std::string&& uri) | |
| URI(const CreateRawMarker&, std::string&& uri) |
Member
Author
There was a problem hiding this comment.
The type has zero size, so it shouldn't make a difference. Marker types are passed by value in the STL, for example std::in_place_t in optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URIto skip some checks when we are creating URIs from existing URIs.ArrayDirectory.Profiler results are available in CORE-383.
TYPE: NO_HISTORY