Skip to content

Move tiledb_ctx_alloc_with_error to the stable API header and use it in the C++ API. - #5667

Merged
teo-tsirpanis merged 2 commits into
mainfrom
teo/core-405-move-tiledb_ctx_alloc_with_error-to-stable-headers-and-use
Oct 10, 2025
Merged

Move tiledb_ctx_alloc_with_error to the stable API header and use it in the C++ API.#5667
teo-tsirpanis merged 2 commits into
mainfrom
teo/core-405-move-tiledb_ctx_alloc_with_error-to-stable-headers-and-use

Conversation

@teo-tsirpanis

@teo-tsirpanis teo-tsirpanis commented Oct 9, 2025

Copy link
Copy Markdown
Member

Move tiledb_ctx_alloc_with_error to the stable API header and use it in the C++ API.


TYPE: C_API
DESC: The tiledb_ctx_alloc_with_error function was moved to the stable API header.


TYPE: CPP_API
DESC: Improved error reporting when creating a context fails.

@teo-tsirpanis
teo-tsirpanis requested a review from ypatia October 9, 2025 00:18
Comment on lines -48 to -52
* that manages everything in the TileDB library. This is a provisional API
* which returns an error object when the context creation fails. This API will
* be replaced with a more proper "v2" of context alloc in the near future. The
* main goal is to use to this to capture potential failures to inform the v2
* alloc design.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this wording. I don't know how the v2 API was envisioned to be, but this existng API looks good to me on its own.

@ypatia ypatia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@teo-tsirpanis

Copy link
Copy Markdown
Member Author

CI failure is unrelated and tracked in CORE-407. @ypatia should we merge this?

@ypatia

ypatia commented Oct 10, 2025

Copy link
Copy Markdown
Member

CI failure is unrelated and tracked in CORE-407. @ypatia should we merge this?

I re-run the job and now it passed. Given this is an unrelated spurious failure we are good to merge.

@teo-tsirpanis
teo-tsirpanis merged commit 827f609 into main Oct 10, 2025
109 of 110 checks passed
@teo-tsirpanis
teo-tsirpanis deleted the teo/core-405-move-tiledb_ctx_alloc_with_error-to-stable-headers-and-use branch October 10, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants