Skip to content

Remove deprecated config param sm.consolidation.buffer_size #5743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bekadavis9 wants to merge 1 commit into
base: main
Choose a base branch
from
+64 −383
Open

Remove deprecated config param sm.consolidation.buffer_size #5743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions test/performance/msys_handle_leakage/unit-cppapi-consolidation-with-timestamps.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*
* The MIT License
*
* @copyright Copyright (c) 2022 TileDB Inc.
* @copyright Copyright (c) 2022-2026 TileDB Inc.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -104,20 +104,15 @@ struct ConsolidationWithTimestampsFx {
};

ConsolidationWithTimestampsFx::ConsolidationWithTimestampsFx()
: vfs_(ctx_) {
Config config;
config.set("sm.consolidation.buffer_size", "1000");
ctx_ = Context(config);
sm_ = ctx_.ptr().get()->storage_manager();
vfs_ = VFS(ctx_);
: vfs_(ctx_)
, sm_(ctx_.ptr().get()->storage_manager()) {
}

ConsolidationWithTimestampsFx::~ConsolidationWithTimestampsFx() {
}

void ConsolidationWithTimestampsFx::set_legacy() {
Config config;
config.set("sm.consolidation.buffer_size", "1000");
config.set("sm.query.sparse_global_order.reader", "legacy");
config.set("sm.query.sparse_unordered_with_dups.reader", "legacy");

Expand Down
5 changes: 1 addition & 4 deletions test/src/test-capi-consolidation-plan.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*
* The MIT License
*
* @copyright Copyright (c) 2023 TileDB, Inc.
* @copyright Copyright (c) 2023-2026 TileDB, Inc.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -68,9 +68,6 @@ struct ConsolidationPlanFx {
};

ConsolidationPlanFx::ConsolidationPlanFx() {
Config config;
config.set("sm.consolidation.buffer_size", "1000");
vfs_test_setup_.update_config(config.ptr().get());
ctx_c_ = vfs_test_setup_.ctx_c;
ctx_ = vfs_test_setup_.ctx();
array_name_ = vfs_test_setup_.array_uri("test_consolidation_plan_array");
Expand Down
3 changes: 1 addition & 2 deletions test/src/test-cppapi-consolidation-plan.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*
* The MIT License
*
* @copyright Copyright (c) 2023 TileDB, Inc.
* @copyright Copyright (c) 2023-2026 TileDB, Inc.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -84,7 +84,6 @@ struct CppConsolidationPlanFx {

CppConsolidationPlanFx::CppConsolidationPlanFx()
: vfs_(ctx_) {
cfg_.set("sm.consolidation.buffer_size", "1000");
ctx_ = Context(cfg_);
vfs_ = VFS(ctx_);

Expand Down
4 changes: 1 addition & 3 deletions test/src/unit-capi-config.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*
* The MIT License
*
* @copyright Copyright (c) 2017-2025 TileDB Inc.
* @copyright Copyright (c) 2017-2026 TileDB Inc.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -254,7 +254,6 @@ void check_save_to_file() {
ss << "sm.compute_concurrency_level " << std::thread::hardware_concurrency()
<< "\n";
ss << "sm.consolidation.amplification 1.0\n";
ss << "sm.consolidation.buffer_size 50000000\n";
ss << "sm.consolidation.max_fragment_size " << std::to_string(UINT64_MAX)
<< "\n";
ss << "sm.consolidation.mode fragments\n";
Expand Down Expand Up @@ -686,7 +685,6 @@ TEST_CASE("C API: Test config iter", "[capi][config]") {
all_param_values["sm.consolidation.purge_deleted_cells"] = "false";
all_param_values["sm.consolidation.step_min_frags"] = "4294967295";
all_param_values["sm.consolidation.step_max_frags"] = "4294967295";
all_param_values["sm.consolidation.buffer_size"] = "50000000";
all_param_values["sm.consolidation.max_fragment_size"] =
std::to_string(UINT64_MAX);
all_param_values["sm.consolidation.step_size_ratio"] = "0.0";
Expand Down
Loading
Loading