Skip to content

Variable supports container streams #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

antiguru
Copy link
Member

Variable supports container streams. The PR achieves this by introducing two new extension traits:

  • ResultsIn applies PathSummary::results_in to every record in the stream.
  • Negate negates the diffs in a stream.

This is in support of allowing columnar data in Materialize recursive contexts.

Adds support for `Variable` for suitable container streams. By default,
support vectors, but leave the possibility for others to implement the new
`Negate` and `ResultsIn` extension traits, which are the required
interface for `Variable`.

Signed-off-by: Moritz Hoffmann <[email protected]>
Copy link
Member

@frankmcsherry frankmcsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thank you!

@frankmcsherry frankmcsherry merged commit 4217a1c into TimelyDataflow:master Feb 12, 2025
7 checks passed
@github-actions github-actions bot mentioned this pull request Feb 12, 2025
@antiguru antiguru deleted the variable_container branch February 13, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants