-
Notifications
You must be signed in to change notification settings - Fork 320
feat: track rows processed during model evaluation #5162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 30 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
c9991a5
Add rows tracking
treysp dba8206
Add flag for supporting row tracking to engine adapters
treysp 296c25c
Run cloud tests in CI
treysp ed6a564
Add engine support flags
treysp 700f006
Use threading.local() instead of locks
treysp 8436adf
Move all tracking into snapshot evaluator, remove seed tracker class
treysp a87df2a
Remove 'processed' and 'inserted' from console output
treysp f7c6866
Add BQ support and track bytes processed
treysp 4df2e32
Remove seed tracking, have snapshot evaluator own tracker instance
treysp 8c2e184
Move tracker class into snapshot module
treysp ff7f096
Fix circular import
treysp fe8adba
Handle snowflake lack of CTAS tracking
treysp bb4b016
Fix tests and snowflake regex
treysp e4e30f0
Change tracking arg name to track_rows_processed
treysp 6b0932a
Report 0 rows correctly
treysp 55c5ffc
Add databricks support
treysp 9e3f2aa
Remove time travel test for cloud engines, handle pyspark DFs in dbx
treysp d45b197
Fix rebase
treysp 3e17479
Seeds are now handled in evaluator
treysp 46717a0
Fix rebase
treysp f227e5a
Handle snowflake table already exists
treysp 775eadf
Query info schema for snowflake CTAS num rows
treysp 81e21cd
Remove databricks, snowflake metadata calls
treysp 7f5f301
Add snowflake test
treysp 175012d
Tidy up
treysp d947fec
PR feedback
treysp 2f6f11a
Remove humanize functions
treysp 0920f39
Make tracking fully instance-based by passing to engine adapter
treysp 8e8ddab
Fix snapshot evaluator tests
treysp 61161ca
Retain previous with_settings settings
treysp 61c7c41
Use humanize for integer/bytes abbreviation
treysp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.