Fix: Respect mssql_merge_exists flag and use merge as a strategy #5544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erindru
reviewed
Oct 15, 2025
sqlmesh/core/engine_adapter/mssql.py
Outdated
| ) | ||
|
|
||
| # For actual conditional overwrites, use MERGE from InsertOverwriteWithMergeMixin | ||
| # For conditional overwrites or when mssql_merge_exists is set, use MERGE from InsertOverwriteWithMergeMixin |
There was a problem hiding this comment.
Actually, InsertOverwriteWithMergeMixin was removed entirely in #5380
There was a problem hiding this comment.
yes good point I'll adapt the comment now that it's consolidated
erindru
approved these changes
Oct 15, 2025
themisvaltinos
force-pushed
the
themis/mergemssql
branch
from
a69c0fe to
c1547b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported that scd type 2 in python models don't respect
mssql_merge_existsflag, but this is a more general issue. This is because this pr: #4531 addedDELETE+INSERTstrategy to be used instead ofMERGEin_insert_overwrite_by_conditionfor mssql. This update respects the flag if the user has opted in to use merge strategy for a particular model and usesmergeinstead.slack thread: https://tobiko-data.slack.com/archives/C044BRE5W4S/p1758704337222309