fix(ngx-dashboard): restore shared state for lazy-registered widget types#6
Merged
Merged
Conversation
…ypes When loadDashboard() runs before a widget type with a shared-state provider is registered (e.g. lazy-loaded modules), the restored state was silently dropped because no provider existed at restore time. Factory self-healing already handled the analogous case for widget factories; this makes shared state symmetric: restoreSharedStates() now buffers unmatched entries, and registerWidgetType() drains the buffer when a matching provider arrives. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
TobyBackstrom
force-pushed
the
fix/shared-state-late-registration
branch
from
c73adca to
b87a2aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WidgetSharedStateProviderstate was silently dropped whenloadDashboard()ran before thewidget type was registered (lazy-loaded modules).
restoreSharedStates()now buffersunmatched entries, and
registerWidgetType()drains the buffer when a matching provider registers later.Test plan
ng test ngx-dashboard --no-watch --browsers=ChromeHeadless— 476/476 pass (was 473)ng lint ngx-dashboard— clean