This repository was archived by the owner on Aug 27, 2020. It is now read-only.
Update nightwatch.conf.js (fixes e2e test) #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It was a test to make it pass on travisCI, and I forgot to revert it back. Thanks. |
|
I've also enabled issues on the project. Hope you like it :). Do you use TypeScript with it ? |
|
Yes :) I was looking for a Typescript template that has testing (unit and e2e) set up along with code coverage 👍 I've also submitted the first issue: #2 😉 |
|
About code coverage with TypeScript, i'm not sure it's accurate. i think we need to compute the source coverage using sourcemaps, using https://github.com/sshev/karma-remap-coverage. If you can make some tests about this, it would be great |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my machine the e2e test fails, the original template also uses 'localhost' instead of '127.0.0.1', do you remember why you changed it from 'localhost' to '127.0.0.1'?