Skip to content
This repository was archived by the owner on Aug 27, 2020. It is now read-only.

Library features #26

Merged
merged 40 commits into from
Oct 1, 2017
Merged

Library features #26

merged 40 commits into from
Oct 1, 2017

Conversation

Toilal
Copy link
Owner

@Toilal Toilal commented Jul 1, 2017

This implements #3.

Known issues:

  • .babelrc contains a env with a library with presets, but they are not used when running npm run build. This causes a bigger JS distribution file than normal, because it embeds some polyfills. See https://babeljs.io/docs/usage/babelrc/#env-option.
  • When cloned locally, it seems to work, but when cloned through vue-cli, minimatch dependency is not found.
  • package.json main entry point is missing.

missing features:

@Toilal Toilal force-pushed the feature/library branch from 359dacd to 14c9bd9 Compare July 4, 2017 20:52
Ffloriel and others added 26 commits July 13, 2017 11:20
* gitignore vscode

* media loader

audio and video tag

* Remove vscode gitignore

* Add \n back

* fix missing closing bracket

* add default values (img, image)
Fix console error`Failed to load resource: net::ERR_INCOMPLETE_CHUNKED_ENCODING`
the glob pattern was too narrow, woudl not catch subpaths.
The parameter to set in package.json is named "browserslist".
Currently, this causes the dev server to listen on all addresses by default, which is not the intended behavior, imo.
We have to investigate how we can get vuejs-templates#688 work without the error reported in vuejs-templates#879
That's actually not a good idea when you e.g. want to access the dev server from your mobile.
* Remove unused fs require from webpack.base.conf.js (vuejs-templates#893)

* cleanup some leftover from reverting vuejs-templates#688
# Conflicts:
#	circle.yml
#	docs/README.md
#	template/.eslintrc.js
#	template/build/webpack.base.conf.js
#	template/package.json
#	template/src/components/Hello.vue
@Toilal Toilal merged commit dab1837 into master Oct 1, 2017
@Toilal Toilal deleted the feature/library branch October 14, 2017 11:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.