fix: Backend startup with BASE_HREF set #631
Open
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JVMerkle
force-pushed
the
bugfix/fix-backend-startup-with-base-href
branch
from
2450ff8 to
776e28e
Compare
|
This is needed by the all in one container. A check if the folder/file exists should be enough to handle the backend only case. |
Backend does not need BASE_HREF patching and crashes if a BASE_HREF is set in the entrypoint.sh. Fixes TomBursch#632
JVMerkle
force-pushed
the
bugfix/fix-backend-startup-with-base-href
branch
from
776e28e to
34e9051
Compare
|
Done, added an extra file check. |
TomBursch
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend does not need BASE_HREF patching and crashes if a BASE_HREF is set in the entrypoint.sh.